-
Notifications
You must be signed in to change notification settings - Fork 940
Update api-documenter to work with new devsite changes #6449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Report 1Affected ProductsNo changes between base commit (1703bb3) and merge commit (4a021bd).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (1703bb3) and merge commit (9acad85).Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the change for functions SDK - works great! Thank you.
Devsite has had some changes and requires some different headers and tags for our reference docs as demonstrated in this CL (internal): https://critique.corp.google.com/cl/461499214
Updating api-documenter to provide this for us, Admin, and Functions. When it is approved, I will publish it to NPM so that Admin and Functions can consume the updates. The update will require an additional command line argument,
--project
, which will determine the path string pointing at the_project.yaml
file.Also updated JS SDK internal docgen script to call the api-documenter with
--project js
, plus insert the "do not edit" message in the right place given the new changes.