Skip to content

Forgot to add firebase version bumps for analytics #6423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jul 7, 2022

Forgot to add firebase to minor version bumps for Analytics. We need to manually add it because changesets won't automatically do a minor bump for the main package when dependent packages get a minor bump.

@hsubox76 hsubox76 requested a review from egilmorez as a code owner July 7, 2022 20:49
@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2022

⚠️ No Changeset found

Latest commit: 46293cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 3 packages
Name Type
@firebase/analytics Minor
firebase Minor
@firebase/analytics-compat Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 requested a review from dwyfrequency July 7, 2022 20:49
@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsubox76 hsubox76 merged commit 1355008 into master Jul 7, 2022
@hsubox76 hsubox76 deleted the ch-versionbump branch July 7, 2022 21:48
@firebase firebase locked and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants