Skip to content

Add installations CDN build and "firebase" entry point #6404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 6, 2022

Conversation

hsubox76
Copy link
Contributor

These were not added in v9 because were under the impression that installations should not be a publicly exposed API but guide docs seem to indicate otherwise: https://firebase.google.com/docs/projects/manage-installations

This allows:

  • importing firebase/installations and firebase/compat/installations - previously users could import @firebase/installations and @firebase/installations-compat directly, but they were not available on the firebase entry point (no @)
  • usage of firebase-installations.js and firebase-installations-compat.js from the gstatic CDN

@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2022

🦋 Changeset detected

Latest commit: 05cab10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hsubox76 hsubox76 requested a review from dwyfrequency June 30, 2022 20:30
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 30, 2022

Size Report 1

Affected Products

  • firebase

    TypeBase (1d3a34d)Merge (3c00d7e)Diff
    firebase-installations-compat.js?13.2 kB? (?)
    firebase-installations.js?59.7 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UjRWs30I4L.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 30, 2022

@russellwheatley
Copy link
Member

This is great news! We're currently using CDN scripts for Flutterfire, and this is the last piece in the puzzle for us as you can read here. Do you have any idea on timeframe when this will be released? 😄 Thanks.

@hsubox76
Copy link
Contributor Author

hsubox76 commented Jul 6, 2022

We have a planned release this Thursday, if I am able to get it merged in time, it should go out then.

Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 5edd81f into master Jul 6, 2022
@hsubox76 hsubox76 deleted the ch-installations branch July 6, 2022 17:58
This was referenced Jul 6, 2022
@firebase firebase locked and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants