Skip to content

Remove unused dependency npm-run-path #6398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2022
Merged

Remove unused dependency npm-run-path #6398

merged 1 commit into from
Jun 28, 2022

Conversation

dwyfrequency
Copy link
Contributor

Remove unused dependency npm-run-path

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2022

⚠️ No Changeset found

Latest commit: 9bf2635

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/analytics

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?19.6 kB? (?)
    esm5?24.2 kB? (?)
    main?25.4 kB? (?)
    module?19.6 kB? (?)

  • @firebase/analytics-compat

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?2.57 kB? (?)
    esm5?2.80 kB? (?)
    main?3.24 kB? (?)
    module?2.57 kB? (?)

  • @firebase/api-documenter

    TypeBase (280c256)Merge (d6eb9c1)Diff
    main?3.95 kB? (?)

  • @firebase/app

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?13.9 kB? (?)
    esm5?18.1 kB? (?)
    main?19.1 kB? (?)
    module?13.9 kB? (?)

  • @firebase/app-check

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?25.1 kB? (?)
    esm5?29.8 kB? (?)
    main?31.0 kB? (?)
    module?25.1 kB? (?)

  • @firebase/app-check-compat

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?2.27 kB? (?)
    esm5?2.48 kB? (?)
    main?2.94 kB? (?)
    module?2.27 kB? (?)

  • @firebase/app-compat

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?5.28 kB? (?)
    esm5?6.13 kB? (?)
    lite?4.06 kB? (?)
    main?6.73 kB? (?)
    module?5.28 kB? (?)

  • @firebase/auth

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?155 kB? (?)
    cordova?183 kB? (?)
    esm5?203 kB? (?)
    main?148 kB? (?)
    module?155 kB? (?)
    react-native?168 kB? (?)

  • @firebase/auth-compat

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?20.2 kB? (?)
    esm5?27.1 kB? (?)
    main?29.6 kB? (?)
    module?20.2 kB? (?)

  • @firebase/auth/cordova

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?183 kB? (?)
    module?183 kB? (?)

  • @firebase/auth/internal

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?166 kB? (?)
    esm5?216 kB? (?)
    main?184 kB? (?)
    module?166 kB? (?)

  • @firebase/auth/react-native

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?168 kB? (?)
    module?168 kB? (?)

  • @firebase/component

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?6.54 kB? (?)
    esm5?8.61 kB? (?)
    main?8.99 kB? (?)
    module?6.54 kB? (?)

  • @firebase/database

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?248 kB? (?)
    esm5?276 kB? (?)
    main?282 kB? (?)
    module?248 kB? (?)

  • @firebase/database-compat

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?18.0 kB? (?)
    esm5?21.1 kB? (?)
    main?21.8 kB? (?)
    module?18.0 kB? (?)

  • @firebase/database-compat/standalone

    TypeBase (280c256)Merge (d6eb9c1)Diff
    main?371 kB? (?)

  • @firebase/firestore

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?262 kB? (?)
    esm5?325 kB? (?)
    main?522 kB? (?)
    module?262 kB? (?)
    react-native?262 kB? (?)

  • @firebase/firestore-compat

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?20.5 kB? (?)
    esm5?27.6 kB? (?)
    main?20.9 kB? (?)
    module?20.5 kB? (?)
    react-native?20.5 kB? (?)

  • @firebase/firestore-lite

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?80.5 kB? (?)
    esm5?96.2 kB? (?)
    main?135 kB? (?)
    module?80.5 kB? (?)
    react-native?80.7 kB? (?)

  • @firebase/functions

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?9.39 kB? (?)
    esm5?11.5 kB? (?)
    main?12.4 kB? (?)
    module?9.39 kB? (?)

  • @firebase/functions-compat

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?1.79 kB? (?)
    esm5?1.98 kB? (?)
    main?2.34 kB? (?)
    module?1.79 kB? (?)

  • @firebase/installations

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?17.8 kB? (?)
    esm5?22.9 kB? (?)
    main?23.8 kB? (?)
    module?17.8 kB? (?)

  • @firebase/installations-compat

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?945 B? (?)
    esm5?1.16 kB? (?)
    main?1.49 kB? (?)
    module?945 B? (?)

  • @firebase/logger

    TypeBase (280c256)Merge (d6eb9c1)Diff
    esm5?4.65 kB? (?)
    main?5.32 kB? (?)
    module?3.25 kB? (?)

  • @firebase/messaging

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?21.3 kB? (?)
    esm5?26.7 kB? (?)
    main?27.4 kB? (?)
    module?21.3 kB? (?)

  • @firebase/messaging-compat

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?2.08 kB? (?)
    esm5?2.51 kB? (?)
    main?2.90 kB? (?)
    module?2.08 kB? (?)

  • @firebase/messaging-sw

    TypeBase (280c256)Merge (d6eb9c1)Diff
    main?30.1 kB? (?)
    module?23.3 kB? (?)

  • @firebase/performance

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?29.1 kB? (?)
    esm5?30.8 kB? (?)
    main?31.2 kB? (?)
    module?29.1 kB? (?)

  • @firebase/performance-compat

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?1.10 kB? (?)
    esm5?1.38 kB? (?)
    main?1.69 kB? (?)
    module?1.10 kB? (?)

  • @firebase/remote-config

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?19.2 kB? (?)
    esm5?24.0 kB? (?)
    main?25.2 kB? (?)
    module?19.2 kB? (?)

  • @firebase/remote-config-compat

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?1.85 kB? (?)
    esm5?2.76 kB? (?)
    main?3.09 kB? (?)
    module?1.85 kB? (?)

  • @firebase/rules-unit-testing

    TypeBase (280c256)Merge (d6eb9c1)Diff
    main?17.6 kB? (?)

  • @firebase/storage

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?54.5 kB? (?)
    esm5?60.5 kB? (?)
    main?57.4 kB? (?)
    module?54.5 kB? (?)

  • @firebase/storage-compat

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?5.67 kB? (?)
    esm5?8.41 kB? (?)
    main?8.82 kB? (?)
    module?5.67 kB? (?)

  • @firebase/util

    TypeBase (280c256)Merge (d6eb9c1)Diff
    browser?21.0 kB? (?)
    esm5?22.3 kB? (?)
    main?27.3 kB? (?)
    module?21.0 kB? (?)

  • @firebase/webchannel-wrapper

    TypeBase (280c256)Merge (d6eb9c1)Diff
    esm5?44.7 kB? (?)
    main?50.8 kB? (?)
    module?43.2 kB? (?)

  • bundle

    43 size changes

    TypeBase (280c256)Merge (d6eb9c1)Diff
    analytics (logEvent)?41.8 kB? (?)
    app-check (CustomProvider)?35.4 kB? (?)
    app-check (ReCaptchaEnterpriseProvider)?37.6 kB? (?)
    app-check (ReCaptchaV3Provider)?37.5 kB? (?)
    auth (Anonymous)?66.3 kB? (?)
    auth (EmailAndPassword)?70.4 kB? (?)
    auth (GoogleFBTwitterGitHubPopup)?90.3 kB? (?)
    auth (GooglePopup)?90.0 kB? (?)
    auth (GoogleRedirect)?90.2 kB? (?)
    auth (Phone)?76.4 kB? (?)
    database (Append to a list of data)?145 kB? (?)
    database (Filtering data)?144 kB? (?)
    database (Listen for child events)?160 kB? (?)
    database (Listen for value events + Detach listeners)?160 kB? (?)
    database (Listen for value events)?160 kB? (?)
    database (Read data once)?156 kB? (?)
    database (Save data as transactions)?162 kB? (?)
    database (Sort data)?145 kB? (?)
    database (Write data)?144 kB? (?)
    firestore (Persistence)?273 kB? (?)
    firestore (Query Cursors)?210 kB? (?)
    firestore (Query)?211 kB? (?)
    firestore (Read data once)?200 kB? (?)
    firestore (Realtime updates)?202 kB? (?)
    firestore (Transaction)?184 kB? (?)
    firestore (Write data)?183 kB? (?)
    firestore-lite (Query Cursors)?210 kB? (?)
    firestore-lite (Query)?210 kB? (?)
    firestore-lite (Read data once)?200 kB? (?)
    firestore-lite (Transaction)?184 kB? (?)
    firestore-lite (Write data)?183 kB? (?)
    functions (call)?29.2 kB? (?)
    messaging (send + receive)?45.1 kB? (?)
    performance (trace)?49.6 kB? (?)
    remote-config (getAndFetch)?44.2 kB? (?)
    storage (getBytes)?37.5 kB? (?)
    storage (getDownloadURL)?39.6 kB? (?)
    storage (getMetadata)?39.0 kB? (?)
    storage (list + listAll)?38.4 kB? (?)
    storage (updateMetadata)?39.3 kB? (?)
    storage (uploadBytes)?43.8 kB? (?)
    storage (uploadBytesResumable)?53.3 kB? (?)
    storage (uploadString)?44.0 kB? (?)

  • firebase

    29 size changes

    TypeBase (280c256)Merge (d6eb9c1)Diff
    firebase-analytics-compat.js?25.8 kB? (?)
    firebase-analytics.js?113 kB? (?)
    firebase-app-check-compat.js?22.8 kB? (?)
    firebase-app-check.js?90.9 kB? (?)
    firebase-app-compat.js?27.7 kB? (?)
    firebase-app.js?87.6 kB? (?)
    firebase-auth-compat.js?125 kB? (?)
    firebase-auth-cordova.js?472 kB? (?)
    firebase-auth-react-native.js?498 kB? (?)
    firebase-auth.js?418 kB? (?)
    firebase-compat.js?794 kB? (?)
    firebase-database-compat.js?166 kB? (?)
    firebase-database.js?606 kB? (?)
    firebase-firestore-compat.js?314 kB? (?)
    firebase-firestore-lite.js?845 kB? (?)
    firebase-firestore.js?845 kB? (?)
    firebase-functions-compat.js?8.12 kB? (?)
    firebase-functions.js?32.1 kB? (?)
    firebase-messaging-compat.js?38.2 kB? (?)
    firebase-messaging-sw.js?107 kB? (?)
    firebase-messaging.js?106 kB? (?)
    firebase-performance-compat.js?30.7 kB? (?)
    firebase-performance-standalone-compat.es2017.js?87.5 kB? (?)
    firebase-performance-standalone-compat.js?65.3 kB? (?)
    firebase-performance.js?123 kB? (?)
    firebase-remote-config-compat.js?27.3 kB? (?)
    firebase-remote-config.js?113 kB? (?)
    firebase-storage-compat.js?38.2 kB? (?)
    firebase-storage.js?146 kB? (?)

  • functions

    TypeBase (280c256)Merge (d6eb9c1)Diff
    main?46 B? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2qkNWLdLDh.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (280c256) and merge commit (d6eb9c1).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GeMlafpeZO.html

@dwyfrequency dwyfrequency marked this pull request as ready for review June 28, 2022 13:45
@dwyfrequency dwyfrequency merged commit 47fefc2 into master Jun 28, 2022
@dwyfrequency dwyfrequency deleted the removeUnusedDeps branch June 28, 2022 20:44
@firebase firebase locked and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@allspain allspain Awaiting requested review from allspain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwyfrequency @google-oss-bot @hsubox76