Skip to content

[Auth] Update user agent detection to better detect iPad #6379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2022
Merged

[Auth] Update user agent detection to better detect iPad #6379

merged 3 commits into from
Jun 23, 2022

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jun 22, 2022

Fixes #6331

This is important for Cordova

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 2d05c2d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sam-gc sam-gc requested a review from egilmorez as a code owner June 22, 2022 22:22
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 22, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (e673dc8)Merge (7af26c3)Diff
    browser155 kB155 kB+43 B (+0.0%)
    cordova183 kB183 kB+43 B (+0.0%)
    esm5203 kB203 kB+43 B (+0.0%)
    main148 kB148 kB+43 B (+0.0%)
    module155 kB155 kB+43 B (+0.0%)
    react-native168 kB168 kB+43 B (+0.0%)

  • @firebase/auth/cordova

    TypeBase (e673dc8)Merge (7af26c3)Diff
    browser183 kB183 kB+43 B (+0.0%)
    module183 kB183 kB+43 B (+0.0%)

  • @firebase/auth/internal

    TypeBase (e673dc8)Merge (7af26c3)Diff
    browser166 kB166 kB+43 B (+0.0%)
    esm5216 kB216 kB+43 B (+0.0%)
    main183 kB184 kB+43 B (+0.0%)
    module166 kB166 kB+43 B (+0.0%)

  • @firebase/auth/react-native

    TypeBase (e673dc8)Merge (7af26c3)Diff
    browser168 kB168 kB+43 B (+0.0%)
    module168 kB168 kB+43 B (+0.0%)

  • bundle

    TypeBase (e673dc8)Merge (7af26c3)Diff
    auth (GoogleFBTwitterGitHubPopup)90.2 kB90.3 kB+41 B (+0.0%)
    auth (GooglePopup)90.0 kB90.0 kB+41 B (+0.0%)
    auth (GoogleRedirect)90.2 kB90.2 kB+41 B (+0.0%)

  • firebase

    TypeBase (e673dc8)Merge (7af26c3)Diff
    firebase-auth-compat.js125 kB125 kB+41 B (+0.0%)
    firebase-auth-cordova.js472 kB472 kB+58 B (+0.0%)
    firebase-auth-react-native.js496 kB497 kB+58 B (+0.0%)
    firebase-auth.js418 kB418 kB+58 B (+0.0%)
    firebase-compat.js794 kB794 kB+41 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/iQmdBvasSu.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 22, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • browserLocalPersistence

      Size

      TypeBase (e673dc8)Merge (7af26c3)Diff
      size34.8 kB34.8 kB+41 B (+0.1%)
      size-with-ext-deps54.5 kB54.5 kB+41 B (+0.1%)

    • browserPopupRedirectResolver

      Size

      TypeBase (e673dc8)Merge (7af26c3)Diff
      size55.8 kB55.8 kB+41 B (+0.1%)
      size-with-ext-deps75.6 kB75.7 kB+41 B (+0.1%)

    • browserSessionPersistence

      Size

      TypeBase (e673dc8)Merge (7af26c3)Diff
      size34.8 kB34.8 kB+41 B (+0.1%)
      size-with-ext-deps54.5 kB54.5 kB+41 B (+0.1%)

    • getAuth

      Size

      TypeBase (e673dc8)Merge (7af26c3)Diff
      size63.5 kB63.5 kB+41 B (+0.1%)
      size-with-ext-deps83.9 kB83.9 kB+41 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vSReGeFn9w.html

@sam-gc sam-gc merged commit 8c52a96 into master Jun 23, 2022
@sam-gc sam-gc deleted the sam-gc/ios-ua branch June 23, 2022 14:55
This was referenced Jul 6, 2022
Merged
Merged
@firebase firebase locked and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@lisajian lisajian Awaiting requested review from lisajian

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

signInWithRedirect with FacebookAuthProvider working in iOS but not in IPadOS
3 participants
@sam-gc @google-oss-bot @yuchenshi