Skip to content

Add a Node ESM build to RUT #6360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nervous-starfishes-crash.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@firebase/rules-unit-testing': patch
---

Add Node ESM build to rules-unit-testing.
11 changes: 11 additions & 0 deletions packages/rules-unit-testing/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@
"description": "",
"author": "Firebase <[email protected]> (https://firebase.google.com/)",
"main": "dist/index.cjs.js",
"exports": {
".": {
"types": "./dist/index.d.ts",
"node": {
"import": "./dist/esm/index.esm.js",
"require": "./dist/index.cjs.js"
},
"default": "./dist/index.cjs.js"
},
"./package.json": "./package.json"
},
"engines": {
"node": ">=10.10.0"
},
Expand Down
34 changes: 28 additions & 6 deletions packages/rules-unit-testing/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,42 @@
import typescriptPlugin from 'rollup-plugin-typescript2';
import pkg from './package.json';
import typescript from 'typescript';
import { emitModulePackageFile } from '../../scripts/build/rollup_emit_module_package_file';

const plugins = [
typescriptPlugin({
typescript
})
];

const es2017BuildPlugins = [
typescriptPlugin({
typescript,
tsconfigOverride: {
compilerOptions: {
target: 'es2017'
}
}
})
];

const deps = Object.keys(
Object.assign({}, pkg.peerDependencies, pkg.dependencies)
);

export default {
input: 'index.ts',
output: [{ file: pkg.main, format: 'cjs', sourcemap: true }],
plugins: [...plugins],
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
};
export default [
{
input: 'index.ts',
output: [{ file: pkg.main, format: 'cjs', sourcemap: true }],
plugins: [...plugins],
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
},
{
input: 'index.ts',
output: [
{ file: pkg.exports['.'].node.import, format: 'es', sourcemap: true }
],
plugins: [...es2017BuildPlugins, emitModulePackageFile()],
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
}
];