Skip to content

Fix E2E reporting to release tracker #6348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Fix E2E reporting to release tracker #6348

merged 1 commit into from
Jun 9, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jun 9, 2022

E2E tests are running fine but there's an issue with the REST call to the release tracker to log the result.

The E2E workflow was recently changed from a workflow_dispatch trigger to a repository_dispatch trigger. This changes how it receives input from the calling REST request, so the old github env variables no longer work. The correct variable is now passed in to the Node script through env variables to the "Tests succeeded" and "Tests failed" steps.

@hsubox76 hsubox76 requested a review from allspain as a code owner June 9, 2022 21:00
@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2022

⚠️ No Changeset found

Latest commit: f90d4c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

@hsubox76 hsubox76 merged commit abcab98 into master Jun 9, 2022
@hsubox76 hsubox76 deleted the ch-e2e-fix branch June 9, 2022 21:24
@google-oss-bot
Copy link
Contributor

@firebase firebase locked and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants