Skip to content

Use workflow inputs for release branch #6346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Use workflow inputs for release branch #6346

merged 1 commit into from
Jun 9, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jun 9, 2022

Running this script in the actual release branch causes some issues in that it will use whatever version of this script is currently in the release branch, which might not be the most current. Use workflow inputs instead to get the "to" and "from" branches for this release.

@hsubox76 hsubox76 requested a review from allspain as a code owner June 9, 2022 18:07
@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2022

⚠️ No Changeset found

Latest commit: 6758fda

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@hsubox76 hsubox76 merged commit 2ce5d19 into master Jun 9, 2022
@hsubox76 hsubox76 deleted the ch-branch-select branch June 9, 2022 19:36
@firebase firebase locked and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants