Split staging release script into 2 parts #6339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restore PR-only workflow
|
Size Report 1Affected ProductsNo changes between base commit (497d34c) and merge commit (e40e44a).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (497d34c) and merge commit (e40e44a).Test Logs |
lahirumaramba
approved these changes
Jun 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated out the part of the staging release workflow that uses changesets/action to generate the "Version Changes" PR because that action is dependent on github context to get the branch and SHA which is basically set when the workflow begins and can't be changed. The main staging workflow unfortunately makes some changes to the release branch before calling changesets/action, so it doesn't work there.
Basically, on step 2 of the Staging Release workflow ("Merge master into release"), the work will split into 2 branches running in parallel. One branch is the staging workflow continuing to its next steps (NPM publish mainly), and the second branch is the "Release PR" workflow beginning, triggered by the merge.