Skip to content

Warn and block staging release if not run in a release branch #6325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2022
Merged

Warn and block staging release if not run in a release branch #6325

merged 2 commits into from
Jun 3, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jun 2, 2022 •
edited
Loading

Log a warning and block the rest of the workflow if this is run in a branch other than "release" or a branch ending in "-releasebranch" (the latter is for a special case of custom branch releases).

@hsubox76 hsubox76 requested a review from allspain as a code owner June 2, 2022 17:33
@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: f0efa80

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 2, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (f84cacd) and merge commit (5cc6652).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/3rhLLH7DjB.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 2, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (f84cacd) and merge commit (5cc6652).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XLjGpBloz5.html

dwyfrequency
dwyfrequency approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 2d6a414 into master Jun 3, 2022
@hsubox76 hsubox76 deleted the ch-staging-guard branch June 3, 2022 17:10
@firebase firebase locked and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

@allspain allspain Awaiting requested review from allspain

@lahirumaramba lahirumaramba Awaiting requested review from lahirumaramba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @dwyfrequency