Skip to content

Add CI script to check package paths #6321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2022
Merged

Add CI script to check package paths #6321

merged 4 commits into from
Jun 2, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jun 1, 2022

  • Add a script to check all the paths to entry points and typings files in package.json and make sure the file they are pointing at exists.
  • Add a workflow to run this in CI on pull_request.
  • Fix errors found in 3 package.json files after running this script.

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2022

🦋 Changeset detected

Latest commit: 6cbb47e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@firebase/auth Patch
@firebase/firestore Patch
@firebase/installations-compat Patch
@firebase/auth-compat Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hsubox76 hsubox76 requested a review from dwyfrequency June 1, 2022 18:41
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (9fddd5c)Merge (a1357a7)Diff
    browser?155 kB? (?)
    cordova?183 kB? (?)
    esm5?202 kB? (?)
    main?148 kB? (?)
    module?155 kB? (?)
    react-native?168 kB? (?)
  • bundle

    TypeBase (9fddd5c)Merge (a1357a7)Diff
    firestore-lite (Query Cursors)67.8 kB208 kB+140 kB (+206.5%)
    firestore-lite (Query)71.0 kB208 kB+137 kB (+192.5%)
    firestore-lite (Read data once)55.4 kB197 kB+142 kB (+256.4%)
    firestore-lite (Transaction)80.0 kB181 kB+101 kB (+126.7%)
    firestore-lite (Write data)65.2 kB181 kB+116 kB (+177.6%)
  • firebase

    TypeBase (9fddd5c)Merge (a1357a7)Diff
    firebase-firestore-lite.js267 kB837 kB+570 kB (+213.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tl3Zvuprfx.html

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit d4b52b6 into master Jun 2, 2022
@hsubox76 hsubox76 deleted the ch-path-checker branch June 2, 2022 16:38
@google-oss-bot google-oss-bot mentioned this pull request Jun 9, 2022
@firebase firebase locked and limited conversation to collaborators Jul 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants