Added GMPID to websocket connection #6232

maneesht · 2022-05-05T20:38:46Z

No description provided.

changeset-bot · 2022-05-05T20:38:49Z

🦋 Changeset detected

Latest commit: 181f4c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/database	Patch
@firebase/database-compat	Patch
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…firebase-js-sdk into add-appid-rtdb-browser

google-oss-bot · 2022-05-05T21:01:03Z

Size Report ¹

Affected Products

@firebase/database
Type Base (9c6808f) Merge (0974d93) Diff
browser 248 kB 248 kB -69 B (-0.0%)
esm5 276 kB 276 kB -52 B (-0.0%)
main 281 kB 281 kB -52 B (-0.0%)
module 248 kB 248 kB -69 B (-0.0%)
@firebase/database-compat/standalone
Type Base (9c6808f) Merge (0974d93) Diff
main 370 kB 370 kB -52 B (-0.0%)

`bundle`

Type	Base (`9c6808f`)	Merge (`0974d93`)	Diff
database (Append to a list of data)	145 kB	145 kB	-89 B (-0.1%)
database (Filtering data)	144 kB	144 kB	-89 B (-0.1%)
database (Listen for child events)	160 kB	160 kB	-89 B (-0.1%)
database (Listen for value events + Detach listeners)	160 kB	160 kB	-89 B (-0.1%)
database (Listen for value events)	160 kB	160 kB	-89 B (-0.1%)
database (Read data once)	152 kB	152 kB	-89 B (-0.1%)
database (Save data as transactions)	162 kB	162 kB	-89 B (-0.1%)
database (Sort data)	146 kB	146 kB	-89 B (-0.1%)
database (Write data)	144 kB	144 kB	-89 B (-0.1%)

firebase
Type Base (9c6808f) Merge (0974d93) Diff
firebase-compat.js 782 kB 782 kB -84 B (-0.0%)
firebase-database-compat.js 166 kB 166 kB -84 B (-0.1%)
firebase-database.js 604 kB 604 kB -134 B (-0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/su9rLM0aKu.html

google-oss-bot · 2022-05-05T21:14:33Z

Size Analysis Report ¹

Affected Products

@firebase/database
- DataSnapshot
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- Database
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- OnDisconnect
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 120 kB 120 kB -126 B (-0.1%)
  size-with-ext-deps 141 kB 141 kB -89 B (-0.1%)
- QueryConstraint
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- TransactionResult
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _QueryImpl
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _QueryParams
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _ReferenceImpl
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _TEST_ACCESS_forceRestClient
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _TEST_ACCESS_hijackHash
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _repoManagerDatabaseFromApp
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _setSDKVersion
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _validatePathString
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- _validateWritablePath
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- child
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- connectDatabaseEmulator
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- enableLogging
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- endAt
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 118 kB 118 kB -126 B (-0.1%)
  size-with-ext-deps 139 kB 139 kB -89 B (-0.1%)
- endBefore
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 119 kB 119 kB -126 B (-0.1%)
  size-with-ext-deps 140 kB 140 kB -89 B (-0.1%)
- equalTo
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 119 kB 119 kB -126 B (-0.1%)
  size-with-ext-deps 140 kB 140 kB -89 B (-0.1%)
- forceLongPolling
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- forceWebSockets
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- get
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 124 kB 124 kB -126 B (-0.1%)
  size-with-ext-deps 145 kB 145 kB -89 B (-0.1%)
- getDatabase
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- goOffline
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- goOnline
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- increment
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- limitToFirst
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- limitToLast
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- off
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 124 kB 124 kB -126 B (-0.1%)
  size-with-ext-deps 145 kB 145 kB -89 B (-0.1%)
- onChildAdded
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 133 kB 133 kB -126 B (-0.1%)
  size-with-ext-deps 154 kB 154 kB -89 B (-0.1%)
- onChildChanged
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 133 kB 133 kB -126 B (-0.1%)
  size-with-ext-deps 154 kB 154 kB -89 B (-0.1%)
- onChildMoved
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 133 kB 133 kB -126 B (-0.1%)
  size-with-ext-deps 154 kB 154 kB -89 B (-0.1%)
- onChildRemoved
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 133 kB 133 kB -126 B (-0.1%)
  size-with-ext-deps 154 kB 154 kB -89 B (-0.1%)
- onDisconnect
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 120 kB 120 kB -126 B (-0.1%)
  size-with-ext-deps 141 kB 141 kB -89 B (-0.1%)
- onValue
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 133 kB 133 kB -126 B (-0.1%)
  size-with-ext-deps 154 kB 154 kB -89 B (-0.1%)
- orderByChild
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 118 kB 118 kB -126 B (-0.1%)
  size-with-ext-deps 139 kB 139 kB -89 B (-0.1%)
- orderByKey
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- orderByPriority
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- orderByValue
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- push
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 118 kB 118 kB -126 B (-0.1%)
  size-with-ext-deps 139 kB 139 kB -89 B (-0.1%)
- query
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- ref
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- refFromURL
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- remove
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- runTransaction
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 135 kB 135 kB -126 B (-0.1%)
  size-with-ext-deps 156 kB 156 kB -89 B (-0.1%)
- serverTimestamp
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 116 kB 116 kB -126 B (-0.1%)
  size-with-ext-deps 137 kB 137 kB -89 B (-0.1%)
- set
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- setPriority
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- setWithPriority
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 117 kB 117 kB -126 B (-0.1%)
  size-with-ext-deps 138 kB 138 kB -89 B (-0.1%)
- startAfter
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 119 kB 119 kB -126 B (-0.1%)
  size-with-ext-deps 140 kB 140 kB -89 B (-0.1%)
- startAt
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 118 kB 118 kB -126 B (-0.1%)
  size-with-ext-deps 139 kB 139 kB -89 B (-0.1%)
- update
  Size
  Type Base (9c6808f) Merge (0974d93) Diff
  size 118 kB 118 kB -126 B (-0.1%)
  size-with-ext-deps 139 kB 139 kB -89 B (-0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/4fHHVXNpCP.html

egilmorez

Changeset looks good, thanks!

Added applicationid to websocket connection

e1e7ee2

maneesht requested a review from jsdt as a code owner May 5, 2022 20:38

Create beige-turkeys-occur.md

416e747

maneesht requested a review from egilmorez as a code owner May 5, 2022 20:39

maneesht added 2 commits May 5, 2022 13:40

Fixed formatting

77ad14f

Merge branch 'add-appid-rtdb-browser' of https://github.com/firebase/…

181f4c2

…firebase-js-sdk into add-appid-rtdb-browser

jsdt approved these changes May 5, 2022

View reviewed changes

maneesht assigned egilmorez May 5, 2022

egilmorez approved these changes May 6, 2022

View reviewed changes

maneesht merged commit 874cdbb into master May 6, 2022

maneesht deleted the add-appid-rtdb-browser branch May 6, 2022 00:27

google-oss-bot mentioned this pull request May 6, 2022

Version Packages #6235

Merged

firebase locked and limited conversation to collaborators Jun 5, 2022

Added GMPID to websocket connection #6232

Added GMPID to websocket connection #6232

Conversation

maneesht commented May 5, 2022

changeset-bot bot commented May 5, 2022 • edited Loading

🦋 Changeset detected

google-oss-bot commented May 5, 2022 • edited Loading

Size Report 1

Affected Products

@firebase/database

@firebase/database-compat/standalone

bundle

firebase

Test Logs

google-oss-bot commented May 5, 2022 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/database

DataSnapshot

Database

OnDisconnect

QueryConstraint

TransactionResult

_QueryImpl

_QueryParams

_ReferenceImpl

_TEST_ACCESS_forceRestClient

_TEST_ACCESS_hijackHash

_repoManagerDatabaseFromApp

_setSDKVersion

_validatePathString

_validateWritablePath

child

connectDatabaseEmulator

enableLogging

endAt

endBefore

equalTo

forceLongPolling

forceWebSockets

get

getDatabase

goOffline

goOnline

increment

limitToFirst

limitToLast

off

onChildAdded

onChildChanged

onChildMoved

onChildRemoved

onDisconnect

onValue

orderByChild

orderByKey

orderByPriority

orderByValue

push

query

ref

refFromURL

remove

runTransaction

serverTimestamp

set

setPriority

setWithPriority

startAfter

startAt

update

Test Logs

egilmorez left a comment

Choose a reason for hiding this comment

changeset-bot bot commented May 5, 2022 •

edited

Loading

google-oss-bot commented May 5, 2022 •

edited

Loading

Size Report ¹

`@firebase/database`

`@firebase/database-compat/standalone`

`bundle`

`firebase`

google-oss-bot commented May 5, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/database`

`DataSnapshot`

`Database`

`OnDisconnect`

`QueryConstraint`

`TransactionResult`

`_QueryImpl`

`_QueryParams`

`_ReferenceImpl`

`_TEST_ACCESS_forceRestClient`

`_TEST_ACCESS_hijackHash`

`_repoManagerDatabaseFromApp`

`_setSDKVersion`

`_validatePathString`

`_validateWritablePath`

`child`

`connectDatabaseEmulator`

`enableLogging`

`endAt`

`endBefore`

`equalTo`

`forceLongPolling`

`forceWebSockets`

`get`

`getDatabase`

`goOffline`

`goOnline`

`increment`

`limitToFirst`

`limitToLast`

`off`

`onChildAdded`

`onChildChanged`

`onChildMoved`

`onChildRemoved`

`onDisconnect`

`onValue`

`orderByChild`

`orderByKey`

`orderByPriority`

`orderByValue`

`push`

`query`

`ref`

`refFromURL`

`remove`

`runTransaction`

`serverTimestamp`

`set`

`setPriority`

`setWithPriority`

`startAfter`

`startAt`

`update`