Add a workflow to merge release into master #6217

hsubox76 · 2022-05-03T22:55:29Z

Manually triggerable workflow that merges release into master. Won't be able to test it until after next release.

changeset-bot · 2022-05-03T22:55:31Z

⚠️ No Changeset found

Latest commit: d7c2485

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2022-05-03T23:19:55Z

Size Report ¹

Affected Products

@firebase/app
Type Base (5c92d9c) Merge (acb4fe5) Diff
browser 13.8 kB 13.8 kB +21 B (+0.2%)
esm5 18.0 kB 18.0 kB +21 B (+0.1%)
main 18.9 kB 19.0 kB +50 B (+0.3%)
module 13.8 kB 13.8 kB +21 B (+0.2%)
@firebase/installations
Type Base (5c92d9c) Merge (acb4fe5) Diff
browser 17.8 kB 17.8 kB +13 B (+0.1%)
esm5 22.9 kB 22.9 kB +13 B (+0.1%)
main 23.7 kB 23.8 kB +42 B (+0.2%)
module 17.8 kB 17.8 kB +13 B (+0.1%)
@firebase/messaging
Type Base (5c92d9c) Merge (acb4fe5) Diff
browser 20.8 kB 20.8 kB +25 B (+0.1%)
esm5 26.2 kB 26.2 kB +25 B (+0.1%)
main 26.8 kB 26.9 kB +50 B (+0.2%)
module 20.8 kB 20.8 kB +25 B (+0.1%)
@firebase/messaging-sw
Type Base (5c92d9c) Merge (acb4fe5) Diff
main 29.6 kB 29.6 kB +50 B (+0.2%)
module 22.8 kB 22.9 kB +25 B (+0.1%)
@firebase/util
Type Base (5c92d9c) Merge (acb4fe5) Diff
browser 23.4 kB 20.5 kB -2.87 kB (-12.3%)
esm5 25.5 kB 21.9 kB -3.68 kB (-14.4%)
main 30.6 kB 26.7 kB -3.86 kB (-12.6%)
module 23.4 kB 20.5 kB -2.87 kB (-12.3%)

`bundle`

43 size changes

Type	Base (`5c92d9c`)	Merge (`acb4fe5`)	Diff
analytics (logEvent)	40.0 kB	41.5 kB	+1.50 kB (+3.8%)
app-check (CustomProvider)	33.7 kB	35.2 kB	+1.51 kB (+4.5%)
app-check (ReCaptchaEnterpriseProvider)	35.9 kB	37.4 kB	+1.51 kB (+4.2%)
app-check (ReCaptchaV3Provider)	35.8 kB	37.4 kB	+1.51 kB (+4.2%)
auth (Anonymous)	63.5 kB	65.0 kB	+1.52 kB (+2.4%)
auth (EmailAndPassword)	67.6 kB	69.1 kB	+1.52 kB (+2.2%)
auth (GoogleFBTwitterGitHubPopup)	87.4 kB	88.9 kB	+1.52 kB (+1.7%)
auth (GooglePopup)	87.1 kB	88.6 kB	+1.52 kB (+1.7%)
auth (GoogleRedirect)	87.3 kB	88.8 kB	+1.52 kB (+1.7%)
auth (Phone)	73.6 kB	75.1 kB	+1.52 kB (+2.1%)
database (Append to a list of data)	144 kB	145 kB	+1.52 kB (+1.1%)
database (Filtering data)	142 kB	144 kB	+1.52 kB (+1.1%)
database (Listen for child events)	158 kB	160 kB	+1.52 kB (+1.0%)
database (Listen for value events + Detach listeners)	158 kB	160 kB	+1.52 kB (+1.0%)
database (Listen for value events)	158 kB	160 kB	+1.52 kB (+1.0%)
database (Read data once)	150 kB	151 kB	+1.52 kB (+1.0%)
database (Save data as transactions)	160 kB	162 kB	+1.52 kB (+0.9%)
database (Sort data)	144 kB	146 kB	+1.52 kB (+1.1%)
database (Write data)	143 kB	144 kB	+1.52 kB (+1.1%)
firestore (Persistence)	263 kB	265 kB	+1.51 kB (+0.6%)
firestore (Query Cursors)	203 kB	204 kB	+1.51 kB (+0.7%)
firestore (Query)	204 kB	205 kB	+1.51 kB (+0.7%)
firestore (Read data once)	192 kB	194 kB	+1.51 kB (+0.8%)
firestore (Realtime updates)	195 kB	196 kB	+1.51 kB (+0.8%)
firestore (Transaction)	177 kB	178 kB	+1.51 kB (+0.9%)
firestore (Write data)	176 kB	177 kB	+1.51 kB (+0.9%)
firestore-lite (Query Cursors)	66.3 kB	67.8 kB	+1.50 kB (+2.3%)
firestore-lite (Query)	69.5 kB	71.0 kB	+1.50 kB (+2.2%)
firestore-lite (Read data once)	53.9 kB	55.4 kB	+1.50 kB (+2.8%)
firestore-lite (Transaction)	71.2 kB	72.7 kB	+1.50 kB (+2.1%)
firestore-lite (Write data)	56.6 kB	58.1 kB	+1.50 kB (+2.7%)
functions (call)	27.6 kB	29.1 kB	+1.50 kB (+5.4%)
messaging (send + receive)	43.3 kB	44.7 kB	+1.34 kB (+3.1%)
performance (trace)	47.7 kB	49.2 kB	+1.50 kB (+3.1%)
remote-config (getAndFetch)	42.4 kB	43.9 kB	+1.50 kB (+3.5%)
storage (getBytes)	35.9 kB	37.4 kB	+1.50 kB (+4.2%)
storage (getDownloadURL)	38.0 kB	39.5 kB	+1.50 kB (+4.0%)
storage (getMetadata)	37.5 kB	39.0 kB	+1.50 kB (+4.0%)
storage (list + listAll)	36.9 kB	38.4 kB	+1.50 kB (+4.1%)
storage (updateMetadata)	37.7 kB	39.2 kB	+1.50 kB (+4.0%)
storage (uploadBytes)	42.3 kB	43.8 kB	+1.50 kB (+3.6%)
storage (uploadBytesResumable)	51.7 kB	53.2 kB	+1.50 kB (+2.9%)
storage (uploadString)	42.5 kB	44.0 kB	+1.50 kB (+3.5%)

`firebase`

15 size changes

Type	Base (`5c92d9c`)	Merge (`acb4fe5`)	Diff
firebase-analytics-compat.js	24.3 kB	25.6 kB	+1.26 kB (+5.2%)
firebase-analytics.js	105 kB	111 kB	+5.89 kB (+5.6%)
firebase-app-compat.js	26.4 kB	27.6 kB	+1.26 kB (+4.8%)
firebase-app.js	81.5 kB	87.4 kB	+5.90 kB (+7.2%)
firebase-auth-react-native.js	492 kB	487 kB	-4.98 kB (-1.0%)
firebase-compat.js	780 kB	781 kB	+1.10 kB (+0.1%)
firebase-messaging-compat.js	36.4 kB	37.5 kB	+1.11 kB (+3.0%)
firebase-messaging-sw.js	101 kB	107 kB	+5.89 kB (+5.8%)
firebase-messaging.js	99.4 kB	105 kB	+5.89 kB (+5.9%)
firebase-performance-compat.js	29.1 kB	30.4 kB	+1.25 kB (+4.3%)
firebase-performance-standalone-compat.es2017.js	86.5 kB	87.1 kB	+626 B (+0.7%)
firebase-performance-standalone-compat.js	64.0 kB	64.9 kB	+925 B (+1.4%)
firebase-performance.js	117 kB	123 kB	+5.89 kB (+5.0%)
firebase-remote-config-compat.js	25.8 kB	27.1 kB	+1.26 kB (+4.9%)
firebase-remote-config.js	106 kB	112 kB	+5.89 kB (+5.5%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/F8jTDg6X91.html

google-oss-bot · 2022-05-03T23:30:48Z

Size Analysis Report ¹

This report is too large (148,440 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/936wLhu48M.html

lahirumaramba

LGTM! Left a few comments

.github/workflows/merge-release-branch.yml

lahirumaramba · 2022-05-04T16:27:30Z

.github/workflows/merge-release-branch.yml

+      contents: write
+    steps:
+      - name: Merge to master
+        uses: actions/[email protected]


Looks like the latest version is v6 now (includes breaking changes). Worth checking if we can use one of the recent versions here.

Will try to bump to v6

lahirumaramba · 2022-05-04T16:30:12Z

.github/workflows/merge-release-branch.yml

+    runs-on: ubuntu-latest
+    # Allow GITHUB_TOKEN to have write permissions
+    permissions:
+      contents: write


Is the goal here to grant GITHUB_TOKEN with default permissions (without write access) and add write access in the workflow?

lahirumaramba · 2022-05-04T16:37:14Z

.github/workflows/merge-release-branch.yml

@@ -0,0 +1,22 @@
+name: Merge Release Into Master
+
+on: repository_dispatch


nit feel free to ignore:
We can set types: here if we want to restrict the manual trigger even further with a specific event_type value in the webhook payload.

on: repository_dispatch: types: [sdk-release-merge]

Will add this when/if we trigger from a webhook. We'll use the button in the Github UI for now.

Add a workflow to merge release into master

d078d55

hsubox76 requested a review from allspain as a code owner May 3, 2022 22:55

hsubox76 requested a review from lahirumaramba May 3, 2022 22:55

lahirumaramba approved these changes May 4, 2022

View reviewed changes

Bump to v6

d7c2485

hsubox76 merged commit 5ce0676 into master May 4, 2022

hsubox76 deleted the ch-release-merge branch May 4, 2022 20:07

firebase locked and limited conversation to collaborators Jun 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add a workflow to merge release into master #6217

Add a workflow to merge release into master #6217

Uh oh!

hsubox76 commented May 3, 2022

Uh oh!

changeset-bot bot commented May 3, 2022 •

edited

Loading

Uh oh!

google-oss-bot commented May 3, 2022 •

edited

Loading

`@firebase/app`

`@firebase/installations`

`@firebase/messaging`

`@firebase/messaging-sw`

`@firebase/util`

`bundle`

`firebase`

Uh oh!

google-oss-bot commented May 3, 2022 •

edited

Loading

Uh oh!

lahirumaramba left a comment

Uh oh!

Uh oh!

lahirumaramba May 4, 2022

Uh oh!

hsubox76 May 4, 2022

Uh oh!

lahirumaramba May 4, 2022

Uh oh!

lahirumaramba May 4, 2022

Uh oh!

hsubox76 May 4, 2022

Uh oh!

Uh oh!

		@@ -0,0 +1,22 @@
		name: Merge Release Into Master

		on: repository_dispatch

Add a workflow to merge release into master #6217

Add a workflow to merge release into master #6217

Uh oh!

Conversation

hsubox76 commented May 3, 2022

Uh oh!

changeset-bot bot commented May 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

google-oss-bot commented May 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/app

@firebase/installations

@firebase/messaging

@firebase/messaging-sw

@firebase/util

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented May 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Test Logs

Uh oh!

lahirumaramba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lahirumaramba May 4, 2022

Choose a reason for hiding this comment

Uh oh!

hsubox76 May 4, 2022

Choose a reason for hiding this comment

Uh oh!

lahirumaramba May 4, 2022

Choose a reason for hiding this comment

Uh oh!

lahirumaramba May 4, 2022

Choose a reason for hiding this comment

Uh oh!

hsubox76 May 4, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

changeset-bot bot commented May 3, 2022 •

edited

Loading

google-oss-bot commented May 3, 2022 •

edited

Loading

Size Report ¹

`@firebase/app`

`@firebase/installations`

`@firebase/messaging`

`@firebase/messaging-sw`

`@firebase/util`

`bundle`

`firebase`

google-oss-bot commented May 3, 2022 •

edited

Loading

Size Analysis Report ¹