Skip to content

Add TransactionOptions #6189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 5, 2022
Merged

Add TransactionOptions #6189

merged 6 commits into from
May 5, 2022

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Apr 27, 2022 •
edited
Loading

Add TransactionOptions parameter to runTransaction method. This will enable control over maximum attempts to commit before transaction fails.

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 6ff1128

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 27, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (e76305a)Merge (52c77fb)Diff
    browser13.8 kB13.8 kB+20 B (+0.1%)
    esm518.0 kB18.0 kB+20 B (+0.1%)
    main18.9 kB19.0 kB+49 B (+0.3%)
    module13.8 kB13.8 kB+20 B (+0.1%)

  • @firebase/firestore

    TypeBase (e76305a)Merge (52c77fb)Diff
    browser253 kB253 kB+211 B (+0.1%)
    esm5314 kB314 kB+202 B (+0.1%)
    main505 kB506 kB+377 B (+0.1%)
    module253 kB253 kB+211 B (+0.1%)
    react-native253 kB253 kB+211 B (+0.1%)

  • @firebase/firestore-lite

    TypeBase (e76305a)Merge (52c77fb)Diff
    browser73.3 kB73.4 kB+188 B (+0.3%)
    esm586.7 kB86.9 kB+180 B (+0.2%)
    main126 kB126 kB+361 B (+0.3%)
    module73.3 kB73.4 kB+188 B (+0.3%)
    react-native73.5 kB73.6 kB+188 B (+0.3%)

  • @firebase/functions

    TypeBase (e76305a)Merge (52c77fb)Diff
    browser9.39 kB9.39 kB-1 B (-0.0%)
    esm511.5 kB11.5 kB-1 B (-0.0%)
    main12.4 kB12.4 kB-1 B (-0.0%)
    module9.39 kB9.39 kB-1 B (-0.0%)

  • @firebase/functions-compat

    TypeBase (e76305a)Merge (52c77fb)Diff
    browser1.79 kB1.79 kB-1 B (-0.1%)
    esm51.98 kB1.98 kB-1 B (-0.1%)
    main2.34 kB2.34 kB-1 B (-0.0%)
    module1.79 kB1.79 kB-1 B (-0.1%)

  • @firebase/installations

    TypeBase (e76305a)Merge (52c77fb)Diff
    browser17.8 kB17.8 kB+13 B (+0.1%)
    esm522.9 kB22.9 kB+13 B (+0.1%)
    main23.7 kB23.8 kB+42 B (+0.2%)
    module17.8 kB17.8 kB+13 B (+0.1%)

  • @firebase/messaging

    TypeBase (e76305a)Merge (52c77fb)Diff
    browser20.8 kB20.8 kB+25 B (+0.1%)
    esm526.2 kB26.2 kB+25 B (+0.1%)
    main26.8 kB26.9 kB+50 B (+0.2%)
    module20.8 kB20.8 kB+25 B (+0.1%)

  • @firebase/messaging-sw

    TypeBase (e76305a)Merge (52c77fb)Diff
    main29.6 kB29.6 kB+50 B (+0.2%)
    module22.8 kB22.9 kB+25 B (+0.1%)

  • @firebase/util

    TypeBase (e76305a)Merge (52c77fb)Diff
    browser23.4 kB20.5 kB-2.87 kB (-12.3%)
    esm525.5 kB21.9 kB-3.68 kB (-14.4%)
    main30.6 kB26.7 kB-3.86 kB (-12.6%)
    module23.4 kB20.5 kB-2.87 kB (-12.3%)

  • bundle

    43 size changes

    TypeBase (e76305a)Merge (52c77fb)Diff
    analytics (logEvent)40.0 kB41.5 kB+1.50 kB (+3.8%)
    app-check (CustomProvider)33.7 kB35.2 kB+1.51 kB (+4.5%)
    app-check (ReCaptchaEnterpriseProvider)35.9 kB37.4 kB+1.51 kB (+4.2%)
    app-check (ReCaptchaV3Provider)35.8 kB37.4 kB+1.51 kB (+4.2%)
    auth (Anonymous)63.5 kB65.0 kB+1.51 kB (+2.4%)
    auth (EmailAndPassword)67.6 kB69.1 kB+1.51 kB (+2.2%)
    auth (GoogleFBTwitterGitHubPopup)87.4 kB88.9 kB+1.51 kB (+1.7%)
    auth (GooglePopup)87.1 kB88.6 kB+1.51 kB (+1.7%)
    auth (GoogleRedirect)87.3 kB88.8 kB+1.51 kB (+1.7%)
    auth (Phone)73.6 kB75.1 kB+1.51 kB (+2.1%)
    database (Append to a list of data)144 kB145 kB+1.52 kB (+1.1%)
    database (Filtering data)142 kB144 kB+1.52 kB (+1.1%)
    database (Listen for child events)158 kB160 kB+1.52 kB (+1.0%)
    database (Listen for value events + Detach listeners)158 kB160 kB+1.52 kB (+1.0%)
    database (Listen for value events)158 kB160 kB+1.52 kB (+1.0%)
    database (Read data once)150 kB151 kB+1.52 kB (+1.0%)
    database (Save data as transactions)160 kB162 kB+1.52 kB (+0.9%)
    database (Sort data)144 kB146 kB+1.52 kB (+1.1%)
    database (Write data)143 kB144 kB+1.52 kB (+1.1%)
    firestore (Persistence)263 kB265 kB+1.50 kB (+0.6%)
    firestore (Query Cursors)203 kB204 kB+1.50 kB (+0.7%)
    firestore (Query)204 kB205 kB+1.50 kB (+0.7%)
    firestore (Read data once)192 kB194 kB+1.50 kB (+0.8%)
    firestore (Realtime updates)195 kB196 kB+1.50 kB (+0.8%)
    firestore (Transaction)177 kB178 kB+1.72 kB (+1.0%)
    firestore (Write data)176 kB177 kB+1.50 kB (+0.9%)
    firestore-lite (Query Cursors)66.3 kB67.8 kB+1.50 kB (+2.3%)
    firestore-lite (Query)69.5 kB71.0 kB+1.50 kB (+2.2%)
    firestore-lite (Read data once)53.9 kB55.4 kB+1.50 kB (+2.8%)
    firestore-lite (Transaction)71.2 kB72.9 kB+1.69 kB (+2.4%)
    firestore-lite (Write data)56.6 kB58.1 kB+1.50 kB (+2.6%)
    functions (call)27.6 kB29.1 kB+1.50 kB (+5.4%)
    messaging (send + receive)43.3 kB44.7 kB+1.34 kB (+3.1%)
    performance (trace)47.7 kB49.2 kB+1.50 kB (+3.1%)
    remote-config (getAndFetch)42.4 kB43.9 kB+1.50 kB (+3.5%)
    storage (getBytes)35.9 kB37.4 kB+1.50 kB (+4.2%)
    storage (getDownloadURL)38.0 kB39.5 kB+1.50 kB (+3.9%)
    storage (getMetadata)37.5 kB39.0 kB+1.50 kB (+4.0%)
    storage (list + listAll)36.9 kB38.4 kB+1.50 kB (+4.1%)
    storage (updateMetadata)37.7 kB39.2 kB+1.50 kB (+4.0%)
    storage (uploadBytes)42.3 kB43.8 kB+1.50 kB (+3.5%)
    storage (uploadBytesResumable)51.7 kB53.2 kB+1.50 kB (+2.9%)
    storage (uploadString)42.5 kB44.0 kB+1.50 kB (+3.5%)

  • firebase

    25 size changes

    TypeBase (e76305a)Merge (52c77fb)Diff
    firebase-analytics-compat.js24.3 kB25.6 kB+1.26 kB (+5.2%)
    firebase-analytics.js105 kB111 kB+5.88 kB (+5.6%)
    firebase-app-check.js90.0 kB90.0 kB-4 B (-0.0%)
    firebase-app-compat.js26.4 kB27.6 kB+1.26 kB (+4.8%)
    firebase-app.js81.5 kB87.4 kB+5.89 kB (+7.2%)
    firebase-auth-cordova.js463 kB463 kB-1 B (-0.0%)
    firebase-auth-react-native.js492 kB487 kB-4.98 kB (-1.0%)
    firebase-auth.js412 kB412 kB-2 B (-0.0%)
    firebase-compat.js780 kB781 kB+1.30 kB (+0.2%)
    firebase-database.js603 kB603 kB-4 B (-0.0%)
    firebase-firestore-compat.js305 kB305 kB+208 B (+0.1%)
    firebase-firestore-lite.js250 kB251 kB+840 B (+0.3%)
    firebase-firestore.js824 kB825 kB+870 B (+0.1%)
    firebase-functions-compat.js8.12 kB8.12 kB-2 B (-0.0%)
    firebase-functions.js32.0 kB32.0 kB-3 B (-0.0%)
    firebase-messaging-compat.js36.4 kB37.5 kB+1.11 kB (+3.0%)
    firebase-messaging-sw.js101 kB107 kB+5.88 kB (+5.8%)
    firebase-messaging.js99.4 kB105 kB+5.88 kB (+5.9%)
    firebase-performance-compat.js29.1 kB30.4 kB+1.25 kB (+4.3%)
    firebase-performance-standalone-compat.es2017.js86.5 kB87.1 kB+623 B (+0.7%)
    firebase-performance-standalone-compat.js64.0 kB64.9 kB+922 B (+1.4%)
    firebase-performance.js117 kB123 kB+5.88 kB (+5.0%)
    firebase-remote-config-compat.js25.8 kB27.1 kB+1.26 kB (+4.9%)
    firebase-remote-config.js106 kB112 kB+5.89 kB (+5.5%)
    firebase-storage.js146 kB146 kB-1 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bm9rQPUWw5.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 27, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (244,946 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PWvrF659v6.html

@tom-andersen tom-andersen requested a review from wu-hui April 28, 2022 13:48
@tom-andersen tom-andersen marked this pull request as ready for review April 28, 2022 13:49
wu-hui
wu-hui approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR!

@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui Apr 29, 2022
@tom-andersen tom-andersen requested a review from wu-hui April 29, 2022 19:49
@tom-andersen
Copy link
Contributor Author

/retest

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@tom-andersen tom-andersen requested a review from egilmorez as a code owner April 29, 2022 22:19
@egilmorez egilmorez requested a review from markarndt April 29, 2022 22:21
@tom-andersen tom-andersen assigned wu-hui and unassigned tom-andersen May 3, 2022
@wu-hui
Copy link
Contributor

wu-hui commented May 4, 2022

LGTM.

@wu-hui wu-hui assigned tom-andersen and unassigned wu-hui May 4, 2022
@tom-andersen tom-andersen merged commit dfab18a into master May 5, 2022
@tom-andersen tom-andersen deleted the tomandersen/transactionOptions branch May 5, 2022 14:13
@google-oss-bot google-oss-bot mentioned this pull request May 5, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@wu-hui wu-hui wu-hui approved these changes

@allspain allspain Awaiting requested review from allspain

@egilmorez egilmorez Awaiting requested review from egilmorez

@markarndt markarndt Awaiting requested review from markarndt

Assignees

@hsubox76 hsubox76

@tom-andersen tom-andersen

@markarndt markarndt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tom-andersen @google-oss-bot @wu-hui @hsubox76 @markarndt