Skip to content

Fix a bug with limitToLast and cursors #6168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2022
Merged

Fix a bug with limitToLast and cursors #6168

merged 2 commits into from
Apr 20, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Apr 20, 2022 •
edited
Loading

Fix: #6134

@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: ec03960

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wu-hui wu-hui requested a review from cherylEnkidu April 20, 2022 14:53
cherylEnkidu
cherylEnkidu approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@cherylEnkidu cherylEnkidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your fix! Could you please add one more test to check
query(collection, orderBy('sort'), startAfter(0), limitToLast(3)) ?

@cherylEnkidu cherylEnkidu assigned wu-hui and unassigned cherylEnkidu Apr 20, 2022
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 20, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (c69c689)Merge (d073c5c)Diff
    browser253 kB253 kB-2 B (-0.0%)
    esm5314 kB314 kB-2 B (-0.0%)
    main505 kB505 kB-2 B (-0.0%)
    module253 kB253 kB-2 B (-0.0%)
    react-native253 kB253 kB-2 B (-0.0%)

  • @firebase/firestore-lite

    TypeBase (c69c689)Merge (d073c5c)Diff
    browser73.1 kB73.1 kB-2 B (-0.0%)
    esm586.5 kB86.5 kB-2 B (-0.0%)
    main126 kB126 kB-2 B (-0.0%)
    module73.1 kB73.1 kB-2 B (-0.0%)
    react-native73.3 kB73.3 kB-2 B (-0.0%)

  • bundle

    TypeBase (c69c689)Merge (d073c5c)Diff
    firestore (Persistence)263 kB263 kB-2 B (-0.0%)
    firestore (Query Cursors)203 kB203 kB-2 B (-0.0%)
    firestore (Query)204 kB204 kB-2 B (-0.0%)
    firestore (Read data once)192 kB192 kB-2 B (-0.0%)
    firestore (Realtime updates)194 kB194 kB-2 B (-0.0%)
    firestore (Transaction)177 kB177 kB-2 B (-0.0%)
    firestore (Write data)176 kB176 kB-2 B (-0.0%)
    firestore-lite (Query Cursors)66.3 kB66.3 kB-2 B (-0.0%)
    firestore-lite (Query)69.4 kB69.4 kB-2 B (-0.0%)

  • firebase

    TypeBase (c69c689)Merge (d073c5c)Diff
    firebase-compat.js780 kB780 kB-2 B (-0.0%)
    firebase-firestore-compat.js304 kB304 kB-2 B (-0.0%)
    firebase-firestore-lite.js250 kB250 kB-2 B (-0.0%)
    firebase-firestore.js824 kB824 kB-2 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/sKp6yrnRmS.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 20, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • addDoc

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size110 kB110 kB-2 B (-0.0%)
      size-with-ext-deps169 kB169 kB-2 B (-0.0%)

    • deleteDoc

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size101 kB101 kB-2 B (-0.0%)
      size-with-ext-deps160 kB160 kB-2 B (-0.0%)

    • disableNetwork

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size89.4 kB89.4 kB-2 B (-0.0%)
      size-with-ext-deps148 kB148 kB-2 B (-0.0%)

    • enableIndexedDbPersistence

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size165 kB165 kB-2 B (-0.0%)
      size-with-ext-deps225 kB225 kB-2 B (-0.0%)

    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size197 kB197 kB-2 B (-0.0%)
      size-with-ext-deps257 kB257 kB-2 B (-0.0%)

    • enableNetwork

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size89.4 kB89.4 kB-2 B (-0.0%)
      size-with-ext-deps148 kB148 kB-2 B (-0.0%)

    • executeWrite

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size99.9 kB99.9 kB-2 B (-0.0%)
      size-with-ext-deps159 kB159 kB-2 B (-0.0%)

    • getDoc

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size126 kB126 kB-2 B (-0.0%)
      size-with-ext-deps185 kB185 kB-2 B (-0.0%)

    • getDocFromCache

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size82.5 kB82.5 kB-2 B (-0.0%)
      size-with-ext-deps140 kB140 kB-2 B (-0.0%)

    • getDocFromServer

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size126 kB126 kB-2 B (-0.0%)
      size-with-ext-deps185 kB185 kB-2 B (-0.0%)

    • getDocs

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size128 kB128 kB-2 B (-0.0%)
      size-with-ext-deps187 kB187 kB-2 B (-0.0%)

    • getDocsFromCache

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size90.0 kB90.0 kB-2 B (-0.0%)
      size-with-ext-deps148 kB148 kB-2 B (-0.0%)

    • getDocsFromServer

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size127 kB127 kB-2 B (-0.0%)
      size-with-ext-deps186 kB186 kB-2 B (-0.0%)

    • loadBundle

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size98.3 kB98.3 kB-2 B (-0.0%)
      size-with-ext-deps157 kB157 kB-2 B (-0.0%)

    • namedQuery

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size76.0 kB76.0 kB-2 B (-0.0%)
      size-with-ext-deps134 kB134 kB-2 B (-0.0%)

    • onSnapshot

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size128 kB128 kB-2 B (-0.0%)
      size-with-ext-deps187 kB187 kB-2 B (-0.0%)

    • onSnapshotsInSync

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size118 kB118 kB-2 B (-0.0%)
      size-with-ext-deps177 kB177 kB-2 B (-0.0%)

    • queryEqual

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size25.9 kB25.9 kB-2 B (-0.0%)
      size-with-ext-deps83.7 kB83.7 kB-2 B (-0.0%)

    • runTransaction

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size110 kB110 kB-2 B (-0.0%)
      size-with-ext-deps169 kB169 kB-2 B (-0.0%)

    • setDoc

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size109 kB109 kB-2 B (-0.0%)
      size-with-ext-deps168 kB168 kB-2 B (-0.0%)

    • snapshotEqual

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size32.7 kB32.7 kB-2 B (-0.0%)
      size-with-ext-deps90.5 kB90.5 kB-2 B (-0.0%)

    • updateDoc

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size109 kB109 kB-2 B (-0.0%)
      size-with-ext-deps168 kB168 kB-2 B (-0.0%)

    • waitForPendingWrites

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size89.8 kB89.8 kB-2 B (-0.0%)
      size-with-ext-deps149 kB149 kB-2 B (-0.0%)

    • writeBatch

      Size

      TypeBase (c69c689)Merge (d073c5c)Diff
      size111 kB111 kB-2 B (-0.0%)
      size-with-ext-deps170 kB170 kB-2 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5aDDhDY4Ds.html

@wu-hui wu-hui merged commit 44948ac into master Apr 20, 2022
@wu-hui wu-hui deleted the wuandy/LimitToLastWithCursor branch April 20, 2022 16:23
@wu-hui wu-hui mentioned this pull request Apr 21, 2022
Closed
@firebase firebase locked and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cherylEnkidu cherylEnkidu cherylEnkidu approved these changes

Assignees

@wu-hui wu-hui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firestore limitToLast with endBefore query contains 1 less document
3 participants
@wu-hui @google-oss-bot @cherylEnkidu