[Auth] Fix redirect middleware #6165

sam-gc · 2022-04-19T00:39:52Z

This change fixes the middleware behavior around redirect. It also ensures that the auth/login-blocked error is only thrown when calling getRedirectResult() after the library is initialized

changeset-bot · 2022-04-19T00:39:54Z

⚠️ No Changeset found

Latest commit: a4f9873

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2022-04-19T01:06:03Z

Size Report ¹

Affected Products

@firebase/auth-compat
Type Base (4f6ee70) Merge (56e24c2) Diff
browser 20.1 kB 20.2 kB +57 B (+0.3%)
esm5 26.9 kB 27.0 kB +57 B (+0.2%)
main 29.5 kB 29.6 kB +68 B (+0.2%)
module 20.1 kB 20.2 kB +57 B (+0.3%)
@firebase/auth/cordova
Type Base (4f6ee70) Merge (56e24c2) Diff
browser 182 kB 182 kB +654 B (+0.4%)
module 182 kB 182 kB +654 B (+0.4%)
@firebase/auth/internal
Type Base (4f6ee70) Merge (56e24c2) Diff
browser 164 kB 165 kB +623 B (+0.4%)
esm5 214 kB 215 kB +731 B (+0.3%)
main 181 kB 182 kB +794 B (+0.4%)
module 164 kB 165 kB +623 B (+0.4%)
@firebase/auth/react-native
Type Base (4f6ee70) Merge (56e24c2) Diff
browser 166 kB 167 kB +512 B (+0.3%)
module 166 kB 167 kB +512 B (+0.3%)

`bundle`

Type	Base (`4f6ee70`)	Merge (`56e24c2`)	Diff
auth (Anonymous)	64.1 kB	64.3 kB	+168 B (+0.3%)
auth (EmailAndPassword)	68.2 kB	68.4 kB	+168 B (+0.2%)
auth (GoogleFBTwitterGitHubPopup)	88.0 kB	88.2 kB	+236 B (+0.3%)
auth (GooglePopup)	87.7 kB	88.0 kB	+236 B (+0.3%)
auth (GoogleRedirect)	87.9 kB	88.2 kB	+236 B (+0.3%)
auth (Phone)	74.2 kB	74.4 kB	+168 B (+0.2%)

`firebase`

Type	Base (`4f6ee70`)	Merge (`56e24c2`)	Diff
firebase-auth-compat.js	124 kB	124 kB	+263 B (+0.2%)
firebase-auth-cordova.js	468 kB	469 kB	+923 B (+0.2%)
firebase-auth-react-native.js	496 kB	497 kB	+755 B (+0.2%)
firebase-auth.js	414 kB	415 kB	+753 B (+0.2%)
firebase-compat.js	779 kB	780 kB	+263 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/Rzor1Gk9n4.html

google-oss-bot · 2022-04-19T01:20:13Z

Size Analysis Report ¹

Affected Products

`@firebase/auth`

ActionCodeOperation
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.0 kB 31.2 kB +168 B (+0.5%)
size-with-ext-deps 49.1 kB 49.3 kB +168 B (+0.3%)
ActionCodeURL
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.9 kB 32.0 kB +168 B (+0.5%)
size-with-ext-deps 50.2 kB 50.4 kB +168 B (+0.3%)
AuthCredential
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.0 kB 31.2 kB +168 B (+0.5%)
size-with-ext-deps 49.1 kB 49.3 kB +168 B (+0.3%)
AuthErrorCodes
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 35.4 kB 35.6 kB +168 B (+0.5%)
size-with-ext-deps 53.5 kB 53.7 kB +168 B (+0.3%)
EmailAuthCredential
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 32.9 kB 33.1 kB +168 B (+0.5%)
size-with-ext-deps 51.0 kB 51.2 kB +168 B (+0.3%)
EmailAuthProvider
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 34.4 kB 34.5 kB +168 B (+0.5%)
size-with-ext-deps 52.7 kB 52.9 kB +168 B (+0.3%)
FacebookAuthProvider
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 36.0 kB 36.1 kB +168 B (+0.5%)
size-with-ext-deps 54.0 kB 54.2 kB +168 B (+0.3%)
FactorId
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.8 kB 31.0 kB +168 B (+0.5%)
size-with-ext-deps 48.9 kB 49.0 kB +168 B (+0.3%)
GithubAuthProvider
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 36.0 kB 36.1 kB +168 B (+0.5%)
size-with-ext-deps 54.0 kB 54.2 kB +168 B (+0.3%)
GoogleAuthProvider
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 36.0 kB 36.1 kB +168 B (+0.5%)
size-with-ext-deps 54.0 kB 54.2 kB +168 B (+0.3%)
OAuthCredential
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 33.0 kB 33.2 kB +168 B (+0.5%)
size-with-ext-deps 51.1 kB 51.3 kB +168 B (+0.3%)
OAuthProvider
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 36.9 kB 37.1 kB +168 B (+0.5%)
size-with-ext-deps 55.0 kB 55.2 kB +168 B (+0.3%)
OperationType
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.8 kB 31.0 kB +168 B (+0.5%)
size-with-ext-deps 48.9 kB 49.1 kB +168 B (+0.3%)
PhoneAuthCredential
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 33.0 kB 33.2 kB +168 B (+0.5%)
size-with-ext-deps 51.1 kB 51.3 kB +168 B (+0.3%)
PhoneAuthProvider
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 34.7 kB 34.9 kB +168 B (+0.5%)
size-with-ext-deps 52.8 kB 53.0 kB +168 B (+0.3%)
PhoneMultiFactorGenerator
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.8 kB 31.9 kB +168 B (+0.5%)
size-with-ext-deps 49.8 kB 50.0 kB +168 B (+0.3%)
ProviderId
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.9 kB 31.1 kB +168 B (+0.5%)
size-with-ext-deps 49.0 kB 49.2 kB +168 B (+0.3%)
RecaptchaVerifier
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 37.2 kB 37.4 kB +168 B (+0.5%)
size-with-ext-deps 55.3 kB 55.5 kB +168 B (+0.3%)
SAMLAuthProvider
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 37.2 kB 37.4 kB +168 B (+0.5%)
size-with-ext-deps 55.3 kB 55.5 kB +168 B (+0.3%)
SignInMethod
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.9 kB 31.1 kB +168 B (+0.5%)
size-with-ext-deps 49.0 kB 49.2 kB +168 B (+0.3%)
TwitterAuthProvider
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 36.0 kB 36.1 kB +168 B (+0.5%)
size-with-ext-deps 54.0 kB 54.2 kB +168 B (+0.3%)
applyActionCode
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.0 kB 31.2 kB +168 B (+0.5%)
size-with-ext-deps 49.1 kB 49.3 kB +168 B (+0.3%)
browserLocalPersistence
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 34.2 kB 34.3 kB +168 B (+0.5%)
size-with-ext-deps 52.3 kB 52.5 kB +168 B (+0.3%)

`browserPopupRedirectResolver`

Size

Type	Base (`4f6ee70`)	Merge (`56e24c2`)	Diff
size	55.1 kB	55.3 kB	+236 B (+0.4%)
size-with-ext-deps	73.4 kB	73.6 kB	+236 B (+0.3%)

Dependency

Type Base (4f6ee70) Merge (56e24c2) Diff

functions

92 dependencies

_addTidIfNecessary
_assert
_castAuth
_createError
_emulatorUrl
_errorWithCustomMessage
_fail
_generateCallbackName
_generateEventId
_getAndClearPendingRedirectStatus
_getBrowserName
_getClientVersion
_getCurrentScheme
_getCurrentUrl
_getFinalTarget
_getInstance
_getProjectConfig
_getRedirectResult
_getRedirectUrl
_getUserLanguage
_iframeCannotSyncWebStorage
_initializeAuthInstance
_isAndroid
_isBlackBerry
_isChromeIOS
_isFirefox
_isHttpOrHttps
_isIE10
_isIEMobile
_isIOS
_isIOSStandalone
_isIframe
_isMobileBrowser
_isOnline
_isSafari
_isWebOS
_link
_link$1
_loadGapi
_loadJS
_logError
_logoutIfInvalidated
_makeTaggedError
_open
_openIframe
_parseToken
_performApiRequest
_performFetchWithErrorHandling
_performSignInRequest
_persistenceKeyName
_processCredentialSavingMfaContextIfNecessary
_prodErrorMap
_reauth
_reauthenticate
_reloadWithoutSaving
_setWindowLocation
_signIn
_signInWithCredential
_tokenExpiresIn
_validateOrigin
_window
_withDefaultResolver
assertStringOrUndefined
createErrorInternal
debugAssert
debugFail
deleteAccount
eventUid
extractProviderData
getAccountInfo
getHandlerBase
getIdTokenResult
getIframeUrl
getScriptParentElement
getVersionForPlatform
isNullRedirectEvent
isRedirectEvent
isUserInvalidated
loadGapi
matchDomain
mergeProviderData
openAsNewWindowIOS
pendingRedirectKey
providerIdForResponse
registerAuth
reload
requestStsToken
resetUnloadedGapiModules
resolverPersistence
secondsStringToMilliseconds
signInWithIdp
utcTimestampToDateString

93 dependencies

_addTidIfNecessary
_assert
_castAuth
_createError
_emulatorUrl
_errorWithCustomMessage
_fail
_generateCallbackName
_generateEventId
_getAndClearPendingRedirectStatus
_getBrowserName
_getClientVersion
_getCurrentScheme
_getCurrentUrl
_getFinalTarget
_getInstance
_getProjectConfig
_getRedirectResult
_getRedirectUrl
_getUserLanguage
_iframeCannotSyncWebStorage
_initializeAuthInstance
_isAndroid
_isBlackBerry
_isChromeIOS
_isFirefox
_isHttpOrHttps
_isIE10
_isIEMobile
_isIOS
_isIOSStandalone
_isIframe
_isMobileBrowser
_isOnline
_isSafari
_isWebOS
_link
_link$1
_loadGapi
_loadJS
_logError
_logoutIfInvalidated
_makeTaggedError
_open
_openIframe
_overrideRedirectResult
_parseToken
_performApiRequest
_performFetchWithErrorHandling
_performSignInRequest
_persistenceKeyName
_processCredentialSavingMfaContextIfNecessary
_prodErrorMap
_reauth
_reauthenticate
_reloadWithoutSaving
_setWindowLocation
_signIn
_signInWithCredential
_tokenExpiresIn
_validateOrigin
_window
_withDefaultResolver
assertStringOrUndefined
createErrorInternal
debugAssert
debugFail
deleteAccount
eventUid
extractProviderData
getAccountInfo
getHandlerBase
getIdTokenResult
getIframeUrl
getScriptParentElement
getVersionForPlatform
isNullRedirectEvent
isRedirectEvent
isUserInvalidated
loadGapi
matchDomain
mergeProviderData
openAsNewWindowIOS
pendingRedirectKey
providerIdForResponse
registerAuth
reload
requestStsToken
resetUnloadedGapiModules
resolverPersistence
secondsStringToMilliseconds
signInWithIdp
utcTimestampToDateString

+ _overrideRedirectResult

browserSessionPersistence
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 34.2 kB 34.3 kB +168 B (+0.5%)
size-with-ext-deps 52.3 kB 52.5 kB +168 B (+0.3%)
checkActionCode
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 32.0 kB 32.1 kB +168 B (+0.5%)
size-with-ext-deps 50.1 kB 50.2 kB +168 B (+0.3%)
confirmPasswordReset
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.0 kB 31.2 kB +168 B (+0.5%)
size-with-ext-deps 49.1 kB 49.3 kB +168 B (+0.3%)
connectAuthEmulator
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 32.5 kB 32.7 kB +168 B (+0.5%)
size-with-ext-deps 50.6 kB 50.8 kB +168 B (+0.3%)
createUserWithEmailAndPassword
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.9 kB 32.1 kB +168 B (+0.5%)
size-with-ext-deps 50.0 kB 50.2 kB +168 B (+0.3%)
debugErrorMap
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 41.9 kB 42.1 kB +168 B (+0.4%)
size-with-ext-deps 60.0 kB 60.2 kB +168 B (+0.3%)
deleteUser
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.8 kB 31.0 kB +168 B (+0.5%)
size-with-ext-deps 48.9 kB 49.1 kB +168 B (+0.3%)
fetchSignInMethodsForEmail
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.2 kB 31.4 kB +168 B (+0.5%)
size-with-ext-deps 49.3 kB 49.5 kB +168 B (+0.3%)
getAdditionalUserInfo
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 32.1 kB 32.3 kB +168 B (+0.5%)
size-with-ext-deps 50.2 kB 50.4 kB +168 B (+0.3%)

`getAuth`

Size

Type	Base (`4f6ee70`)	Merge (`56e24c2`)	Diff
size	62.8 kB	63.0 kB	+236 B (+0.4%)
size-with-ext-deps	81.6 kB	81.9 kB	+236 B (+0.3%)

Dependency

Type Base (4f6ee70) Merge (56e24c2) Diff

functions

105 dependencies

_addTidIfNecessary
_allSettled
_assert
_castAuth
_createError
_deleteDatabase
_deleteObject
_emulatorUrl
_errorWithCustomMessage
_fail
_generateCallbackName
_generateEventId
_getActiveServiceWorker
_getAndClearPendingRedirectStatus
_getBrowserName
_getClientVersion
_getCurrentScheme
_getCurrentUrl
_getFinalTarget
_getInstance
_getProjectConfig
_getRedirectResult
_getRedirectUrl
_getServiceWorkerController
_getUserLanguage
_getWorkerGlobalScope
_iframeCannotSyncWebStorage
_initializeAuthInstance
_isAndroid
_isBlackBerry
_isChromeIOS
_isFirefox
_isHttpOrHttps
_isIE10
_isIEMobile
_isIOS
_isIOSStandalone
_isIframe
_isMobileBrowser
_isOnline
_isSafari
_isWebOS
_isWorker
_link
_link$1
_loadGapi
_loadJS
_logError
_logoutIfInvalidated
_makeTaggedError
_open
_openDatabase
_openIframe
_parseToken
_performApiRequest
_performFetchWithErrorHandling
_performSignInRequest
_persistenceKeyName
_processCredentialSavingMfaContextIfNecessary
_prodErrorMap
_putObject
_reauth
_reauthenticate
_reloadWithoutSaving
_setWindowLocation
_signIn
_signInWithCredential
_tokenExpiresIn
_validateOrigin
_window
_withDefaultResolver
assertStringOrUndefined
createErrorInternal
debugAssert
debugFail
deleteAccount
eventUid
extractProviderData
getAccountInfo
getAuth
getHandlerBase
getIdTokenResult
getIframeUrl
getObject
getObjectStore
getScriptParentElement
getVersionForPlatform
initializeAuth
isNullRedirectEvent
isRedirectEvent
isUserInvalidated
loadGapi
matchDomain
mergeProviderData
openAsNewWindowIOS
pendingRedirectKey
providerIdForResponse
registerAuth
reload
requestStsToken
resetUnloadedGapiModules
resolverPersistence
secondsStringToMilliseconds
signInWithIdp
utcTimestampToDateString

106 dependencies

_addTidIfNecessary
_allSettled
_assert
_castAuth
_createError
_deleteDatabase
_deleteObject
_emulatorUrl
_errorWithCustomMessage
_fail
_generateCallbackName
_generateEventId
_getActiveServiceWorker
_getAndClearPendingRedirectStatus
_getBrowserName
_getClientVersion
_getCurrentScheme
_getCurrentUrl
_getFinalTarget
_getInstance
_getProjectConfig
_getRedirectResult
_getRedirectUrl
_getServiceWorkerController
_getUserLanguage
_getWorkerGlobalScope
_iframeCannotSyncWebStorage
_initializeAuthInstance
_isAndroid
_isBlackBerry
_isChromeIOS
_isFirefox
_isHttpOrHttps
_isIE10
_isIEMobile
_isIOS
_isIOSStandalone
_isIframe
_isMobileBrowser
_isOnline
_isSafari
_isWebOS
_isWorker
_link
_link$1
_loadGapi
_loadJS
_logError
_logoutIfInvalidated
_makeTaggedError
_open
_openDatabase
_openIframe
_overrideRedirectResult
_parseToken
_performApiRequest
_performFetchWithErrorHandling
_performSignInRequest
_persistenceKeyName
_processCredentialSavingMfaContextIfNecessary
_prodErrorMap
_putObject
_reauth
_reauthenticate
_reloadWithoutSaving
_setWindowLocation
_signIn
_signInWithCredential
_tokenExpiresIn
_validateOrigin
_window
_withDefaultResolver
assertStringOrUndefined
createErrorInternal
debugAssert
debugFail
deleteAccount
eventUid
extractProviderData
getAccountInfo
getAuth
getHandlerBase
getIdTokenResult
getIframeUrl
getObject
getObjectStore
getScriptParentElement
getVersionForPlatform
initializeAuth
isNullRedirectEvent
isRedirectEvent
isUserInvalidated
loadGapi
matchDomain
mergeProviderData
openAsNewWindowIOS
pendingRedirectKey
providerIdForResponse
registerAuth
reload
requestStsToken
resetUnloadedGapiModules
resolverPersistence
secondsStringToMilliseconds
signInWithIdp
utcTimestampToDateString

+ _overrideRedirectResult

getIdToken
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.8 kB 31.0 kB +168 B (+0.5%)
size-with-ext-deps 48.9 kB 49.1 kB +168 B (+0.3%)
getIdTokenResult
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.8 kB 30.9 kB +168 B (+0.5%)
size-with-ext-deps 48.9 kB 49.0 kB +168 B (+0.3%)
getMultiFactorResolver
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 33.5 kB 33.7 kB +168 B (+0.5%)
size-with-ext-deps 51.6 kB 51.8 kB +168 B (+0.3%)
getRedirectResult
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 38.4 kB 38.6 kB +168 B (+0.4%)
size-with-ext-deps 56.5 kB 56.7 kB +168 B (+0.3%)
inMemoryPersistence
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.8 kB 30.9 kB +168 B (+0.5%)
size-with-ext-deps 48.9 kB 49.0 kB +168 B (+0.3%)
indexedDBLocalPersistence
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 38.2 kB 38.4 kB +168 B (+0.4%)
size-with-ext-deps 56.3 kB 56.5 kB +168 B (+0.3%)
initializeAuth
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.0 kB 31.2 kB +168 B (+0.5%)
size-with-ext-deps 49.6 kB 49.8 kB +168 B (+0.3%)
isSignInWithEmailLink
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 32.0 kB 32.1 kB +168 B (+0.5%)
size-with-ext-deps 50.3 kB 50.5 kB +168 B (+0.3%)
linkWithCredential
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.8 kB 32.0 kB +168 B (+0.5%)
size-with-ext-deps 49.9 kB 50.1 kB +168 B (+0.3%)
linkWithPhoneNumber
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 35.5 kB 35.7 kB +168 B (+0.5%)
size-with-ext-deps 53.6 kB 53.8 kB +168 B (+0.3%)
linkWithPopup
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 42.0 kB 42.2 kB +168 B (+0.4%)
size-with-ext-deps 60.1 kB 60.3 kB +168 B (+0.3%)
linkWithRedirect
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 37.2 kB 37.4 kB +168 B (+0.5%)
size-with-ext-deps 55.3 kB 55.5 kB +168 B (+0.3%)
multiFactor
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 33.0 kB 33.1 kB +168 B (+0.5%)
size-with-ext-deps 51.1 kB 51.2 kB +168 B (+0.3%)
onAuthStateChanged
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.8 kB 31.0 kB +168 B (+0.5%)
size-with-ext-deps 48.9 kB 49.1 kB +168 B (+0.3%)
onIdTokenChanged
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.8 kB 31.0 kB +168 B (+0.5%)
size-with-ext-deps 48.9 kB 49.1 kB +168 B (+0.3%)
parseActionCodeURL
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.9 kB 32.1 kB +168 B (+0.5%)
size-with-ext-deps 50.2 kB 50.4 kB +168 B (+0.3%)
prodErrorMap
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.8 kB 30.9 kB +168 B (+0.5%)
size-with-ext-deps 48.9 kB 49.0 kB +168 B (+0.3%)
reauthenticateWithCredential
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 32.4 kB 32.5 kB +168 B (+0.5%)
size-with-ext-deps 50.5 kB 50.6 kB +168 B (+0.3%)
reauthenticateWithPhoneNumber
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 36.0 kB 36.2 kB +168 B (+0.5%)
size-with-ext-deps 54.1 kB 54.3 kB +168 B (+0.3%)
reauthenticateWithPopup
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 42.0 kB 42.2 kB +168 B (+0.4%)
size-with-ext-deps 60.1 kB 60.3 kB +168 B (+0.3%)
reauthenticateWithRedirect
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 37.0 kB 37.1 kB +168 B (+0.5%)
size-with-ext-deps 55.1 kB 55.2 kB +168 B (+0.3%)
reload
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.8 kB 30.9 kB +168 B (+0.5%)
size-with-ext-deps 48.8 kB 49.0 kB +168 B (+0.3%)
sendEmailVerification
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.8 kB 32.0 kB +168 B (+0.5%)
size-with-ext-deps 49.9 kB 50.1 kB +168 B (+0.3%)
sendPasswordResetEmail
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.7 kB 31.9 kB +168 B (+0.5%)
size-with-ext-deps 49.8 kB 50.0 kB +168 B (+0.3%)
sendSignInLinkToEmail
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.8 kB 31.9 kB +168 B (+0.5%)
size-with-ext-deps 49.9 kB 50.0 kB +168 B (+0.3%)
setPersistence
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.8 kB 31.0 kB +168 B (+0.5%)
size-with-ext-deps 48.9 kB 49.1 kB +168 B (+0.3%)
signInAnonymously
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 32.1 kB 32.2 kB +168 B (+0.5%)
size-with-ext-deps 50.2 kB 50.3 kB +168 B (+0.3%)
signInWithCredential
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 32.2 kB 32.3 kB +168 B (+0.5%)
size-with-ext-deps 50.3 kB 50.4 kB +168 B (+0.3%)
signInWithCustomToken
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.9 kB 32.1 kB +168 B (+0.5%)
size-with-ext-deps 50.0 kB 50.2 kB +168 B (+0.3%)
signInWithEmailAndPassword
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 35.8 kB 36.0 kB +168 B (+0.5%)
size-with-ext-deps 54.2 kB 54.3 kB +168 B (+0.3%)
signInWithEmailLink
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 36.0 kB 36.2 kB +168 B (+0.5%)
size-with-ext-deps 54.4 kB 54.5 kB +168 B (+0.3%)
signInWithPhoneNumber
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 35.8 kB 36.0 kB +168 B (+0.5%)
size-with-ext-deps 53.9 kB 54.1 kB +168 B (+0.3%)
signInWithPopup
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 42.0 kB 42.2 kB +168 B (+0.4%)
size-with-ext-deps 60.1 kB 60.3 kB +168 B (+0.3%)
signInWithRedirect
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 36.7 kB 36.8 kB +168 B (+0.5%)
size-with-ext-deps 54.8 kB 54.9 kB +168 B (+0.3%)
signOut
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.8 kB 31.0 kB +168 B (+0.5%)
size-with-ext-deps 48.9 kB 49.1 kB +168 B (+0.3%)
unlink
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.4 kB 31.5 kB +168 B (+0.5%)
size-with-ext-deps 49.5 kB 49.6 kB +168 B (+0.3%)
updateCurrentUser
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.8 kB 31.0 kB +168 B (+0.5%)
size-with-ext-deps 48.9 kB 49.1 kB +168 B (+0.3%)
updateEmail
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.1 kB 31.3 kB +168 B (+0.5%)
size-with-ext-deps 49.2 kB 49.3 kB +168 B (+0.3%)
updatePassword
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.1 kB 31.3 kB +168 B (+0.5%)
size-with-ext-deps 49.2 kB 49.3 kB +168 B (+0.3%)
updatePhoneNumber
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.5 kB 31.7 kB +168 B (+0.5%)
size-with-ext-deps 49.6 kB 49.8 kB +168 B (+0.3%)
updateProfile
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.3 kB 31.5 kB +168 B (+0.5%)
size-with-ext-deps 49.4 kB 49.5 kB +168 B (+0.3%)
useDeviceLanguage
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 30.8 kB 31.0 kB +168 B (+0.5%)
size-with-ext-deps 48.9 kB 49.1 kB +168 B (+0.3%)
verifyBeforeUpdateEmail
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 31.9 kB 32.0 kB +168 B (+0.5%)
size-with-ext-deps 49.9 kB 50.1 kB +168 B (+0.3%)
verifyPasswordResetCode
Size
Type Base (4f6ee70) Merge (56e24c2) Diff
size 32.0 kB 32.2 kB +168 B (+0.5%)
size-with-ext-deps 50.1 kB 50.3 kB +168 B (+0.3%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/373ovcTGFM.html

packages/auth/src/platform_browser/auth.test.ts

packages/auth/test/integration/webdriver/redirect.test.ts

* Fix redirect middleware * Fix compat tests * Formatting * PR feedback

sam-gc added 3 commits April 18, 2022 17:29

Fix redirect middleware

8c0a0ff

Fix compat tests

c97a436

Formatting

a6456a0

sam-gc assigned avolkovi Apr 19, 2022

sam-gc requested a review from avolkovi as a code owner April 19, 2022 00:39

sam-gc assigned hsubox76 Apr 19, 2022

sam-gc requested review from lisajian and yuchenshi as code owners April 19, 2022 00:39

sam-gc assigned yuchenshi Apr 19, 2022

yuchenshi approved these changes Apr 21, 2022

View reviewed changes

packages/auth/src/platform_browser/auth.test.ts Outdated Show resolved Hide resolved

packages/auth/test/integration/webdriver/redirect.test.ts Show resolved Hide resolved

PR feedback

a4f9873

sam-gc merged commit 3785b07 into auth-middleware Apr 25, 2022

sam-gc deleted the sam-gc/middleware-redirect branch April 25, 2022 20:25

sam-gc added a commit that referenced this pull request May 4, 2022

[Auth] Fix redirect middleware (#6165)

25c0b60

* Fix redirect middleware * Fix compat tests * Formatting * PR feedback

firebase locked and limited conversation to collaborators May 26, 2022

[Auth] Fix redirect middleware #6165

[Auth] Fix redirect middleware #6165

Conversation

sam-gc commented Apr 19, 2022

changeset-bot bot commented Apr 19, 2022 • edited Loading

⚠️ No Changeset found

google-oss-bot commented Apr 19, 2022 • edited Loading

Size Report 1

Affected Products

@firebase/auth-compat

@firebase/auth/cordova

@firebase/auth/internal

@firebase/auth/react-native

bundle

firebase

Test Logs

google-oss-bot commented Apr 19, 2022 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/auth

ActionCodeOperation

ActionCodeURL

AuthCredential

AuthErrorCodes

EmailAuthCredential

EmailAuthProvider

FacebookAuthProvider

FactorId

GithubAuthProvider

GoogleAuthProvider

OAuthCredential

OAuthProvider

OperationType

PhoneAuthCredential

PhoneAuthProvider

PhoneMultiFactorGenerator

ProviderId

RecaptchaVerifier

SAMLAuthProvider

SignInMethod

TwitterAuthProvider

applyActionCode

browserLocalPersistence

browserPopupRedirectResolver

browserSessionPersistence

checkActionCode

confirmPasswordReset

connectAuthEmulator

createUserWithEmailAndPassword

debugErrorMap

deleteUser

fetchSignInMethodsForEmail

getAdditionalUserInfo

getAuth

getIdToken

getIdTokenResult

getMultiFactorResolver

getRedirectResult

inMemoryPersistence

indexedDBLocalPersistence

initializeAuth

isSignInWithEmailLink

linkWithCredential

linkWithPhoneNumber

linkWithPopup

linkWithRedirect

multiFactor

onAuthStateChanged

onIdTokenChanged

parseActionCodeURL

prodErrorMap

reauthenticateWithCredential

reauthenticateWithPhoneNumber

reauthenticateWithPopup

reauthenticateWithRedirect

reload

sendEmailVerification

sendPasswordResetEmail

sendSignInLinkToEmail

setPersistence

changeset-bot bot commented Apr 19, 2022 •

edited

Loading

google-oss-bot commented Apr 19, 2022 •

edited

Loading

Size Report ¹

`@firebase/auth-compat`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`bundle`

`firebase`

google-oss-bot commented Apr 19, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/auth`

`ActionCodeOperation`

`ActionCodeURL`

`AuthCredential`

`AuthErrorCodes`

`EmailAuthCredential`

`EmailAuthProvider`

`FacebookAuthProvider`

`FactorId`

`GithubAuthProvider`

`GoogleAuthProvider`

`OAuthCredential`

`OAuthProvider`

`OperationType`

`PhoneAuthCredential`

`PhoneAuthProvider`

`PhoneMultiFactorGenerator`

`ProviderId`

`RecaptchaVerifier`

`SAMLAuthProvider`

`SignInMethod`

`TwitterAuthProvider`

`applyActionCode`

`browserLocalPersistence`

`browserPopupRedirectResolver`

`browserSessionPersistence`

`checkActionCode`

`confirmPasswordReset`

`connectAuthEmulator`

`createUserWithEmailAndPassword`

`debugErrorMap`

`deleteUser`

`fetchSignInMethodsForEmail`

`getAdditionalUserInfo`

`getAuth`

`getIdToken`

`getIdTokenResult`

`getMultiFactorResolver`

`getRedirectResult`

`inMemoryPersistence`

`indexedDBLocalPersistence`

`initializeAuth`

`isSignInWithEmailLink`

`linkWithCredential`

`linkWithPhoneNumber`

`linkWithPopup`

`linkWithRedirect`

`multiFactor`

`onAuthStateChanged`

`onIdTokenChanged`

`parseActionCodeURL`

`prodErrorMap`

`reauthenticateWithCredential`

`reauthenticateWithPhoneNumber`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`reload`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`setPersistence`

`signInAnonymously`

`signInWithCredential`

`signInWithCustomToken`

`signInWithEmailAndPassword`

`signInWithEmailLink`

`signInWithPhoneNumber`

`signInWithPopup`

`signInWithRedirect`