Add httpsCallableFromURL #6162

inlined · 2022-04-16T17:25:14Z

Sorry for a late-coming urgent change; AFAICT nobody on the SDK team could staff these changes, so I'm trying to write the change for the top 3 SDKs before I/O freeze.

For context, see go/cf3v2-crash-landing.
For API approval, see go/callable-functions-custom-urls

changeset-bot · 2022-04-16T17:25:16Z

🦋 Changeset detected

Latest commit: 24e82d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/functions-compat	Patch
@firebase/functions	Patch
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-04-16T17:28:03Z

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

google-oss-bot · 2022-04-16T17:44:27Z

Size Report ¹

Affected Products

@firebase/functions
Type Base (38da5d9) Merge (852f765) Diff
browser 8.99 kB 9.39 kB +397 B (+4.4%)
esm5 11.1 kB 11.5 kB +414 B (+3.7%)
main 11.8 kB 12.4 kB +529 B (+4.5%)
module 8.99 kB 9.39 kB +397 B (+4.4%)
@firebase/functions-compat
Type Base (38da5d9) Merge (852f765) Diff
browser 1.68 kB 1.79 kB +111 B (+6.6%)
esm5 1.83 kB 1.98 kB +148 B (+8.1%)
main 2.20 kB 2.34 kB +137 B (+6.2%)
module 1.68 kB 1.79 kB +111 B (+6.6%)
bundle
Type Base (38da5d9) Merge (852f765) Diff
functions (call) 27.6 kB 27.6 kB +40 B (+0.1%)
firebase
Type Base (38da5d9) Merge (852f765) Diff
firebase-compat.js 779 kB 779 kB +179 B (+0.0%)
firebase-functions-compat.js 7.95 kB 8.12 kB +169 B (+2.1%)
firebase-functions.js 31.1 kB 32.0 kB +947 B (+3.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/3gHFrqXHAY.html

google-oss-bot · 2022-04-16T17:57:23Z

Size Analysis Report ¹

Affected Products

`@firebase/functions`

`httpsCallable`

Size

Type	Base (`38da5d9`)	Merge (`852f765`)	Diff
size	5.98 kB	6.02 kB	+38 B (+0.6%)
size-with-ext-deps	21.1 kB	21.1 kB	+40 B (+0.2%)

Dependency

Type Base (38da5d9) Merge (852f765) Diff

functions

11 dependencies

_errorForResponse
call
codeForHTTPStatus
decode
encode
failAfter
httpsCallable
httpsCallable$1
mapValues
postJSON
registerFunctions

12 dependencies

_errorForResponse
call
callAtURL
codeForHTTPStatus
decode
encode
failAfter
httpsCallable
httpsCallable$1
mapValues
postJSON
registerFunctions

+ callAtURL

`httpsCallableFromURL`

Size

Type	Base (`38da5d9`)	Merge (`852f765`)	Diff
size	?	5.97 kB	? (?)
size-with-ext-deps	?	21.1 kB	? (?)

Dependency

Type	Base (`38da5d9`)	Merge (`852f765`)	Diff
functions	?	11 dependencies _errorForResponse callAtURL codeForHTTPStatus decode encode failAfter httpsCallableFromURL httpsCallableFromURL$1 mapValues postJSON registerFunctions	?
classes	?	ContextProvider FunctionsError FunctionsService	?
variables	?	APP_CHECK_INTERNAL_NAME AUTH_INTERNAL_NAME DEFAULT_REGION FUNCTIONS_TYPE LONG_TYPE MESSAGING_INTERNAL_NAME UNSIGNED_LONG_TYPE errorCodeMap name version	?
enums	?		?

External Dependency

Module	Base (`38da5d9`)	Merge (`852f765`)	Diff
`@firebase/app`	?	_registerComponent registerVersion	?
`@firebase/component`	?	Component	?
`@firebase/util`	?	FirebaseError getModularInstance	?

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/oMe5L3sPEF.html

hsubox76

Thanks for the PR, just a few small changes.

hsubox76 · 2022-04-18T17:28:23Z

.changeset/new-bugs-think.md

+---
+"@firebase/functions-compat": patch
+"@firebase/functions": patch
+"firebase-size-analysis": patch


firebase-size-analysis can be removed, it's in the ignored changesets list. Actually, the change to that file seems unneeded (see below) so also for that reason.

hsubox76 · 2022-04-18T17:31:41Z

e2e/sample-apps/modular.js

@@ -118,11 +118,28 @@ async function authLogout(app) {
 */
 async function callFunctions(app) {
  console.log('[FUNCTIONS] start');
-  const functions = getFunctions(app);
-  const callTest = httpsCallable(functions, 'callTest');
+  let functions = getFunctions(app);


Is functions reassigned?

hsubox76 · 2022-04-18T17:33:22Z

packages/functions/src/api.ts

@@ -90,3 +91,23 @@ export function httpsCallable<RequestData = unknown, ResponseData = unknown>(
    options
  );
 }
+
+/**
+ * Returns a reference to the callable HTTPS trigger with the given name.


"given name" => "specified URL"?

hsubox76 · 2022-04-18T17:36:39Z

repo-scripts/size-analysis/bundle-definitions/functions.json

@@ -22,11 +22,12 @@
            "path": "functions",
            "imports": [
              "getFunctions",
-              "httpsCallable"
+              "httpsCallable",
+              "httpsCallableFromURL"


Doesn't need to be added here, this represents a typical bundle of imports for a use case and it's not a common case that a developer would use httpsCallable and httpsCallableFromURL in the same app. In any case, since httpsCallable wraps the core code of httpsCallableFromURL, the bundle size should be about the same.

hsubox76 · 2022-04-18T19:46:38Z

repo-scripts/size-analysis/bundle-definitions/functions.json

@@ -29,4 +29,4 @@
      }
    ]
  }
-]
+]


It still thinks there's a whitespace change.

Dunno why my formatter keeps on insisting on this. Edited in vim to avoid stripping the newline.

hsubox76 · 2022-04-18T19:47:39Z

e2e/sample-apps/modular.js

@@ -122,7 +122,24 @@ async function callFunctions(app) {
  const callTest = httpsCallable(functions, 'callTest');


functions isn't reassigned but it looks like callTest is, and does still need the let.

repo-scripts/size-analysis/bundle-definitions/functions.json

hsubox76

LG, thanks!

Add httpsCallableFromURL

f7d06bc

inlined requested review from allspain and hsubox76 as code owners April 16, 2022 17:25

Create new-bugs-think.md

8fec94c

inlined requested a review from egilmorez as a code owner April 16, 2022 17:25

Update API reports

a5108a6

google-oss-bot added the doc-changes PRs that affect docs label Apr 16, 2022

github-actions bot assigned egilmorez Apr 16, 2022

inlined added 3 commits April 16, 2022 13:49

Run formatter

cdd1221

Remove support for the emulator since we don't have a name

95b26f8

Formatter

a9fb73b

hsubox76 reviewed Apr 18, 2022

View reviewed changes

PR feedback

87e21de

hsubox76 reviewed Apr 18, 2022

View reviewed changes

Fixes again

724f9a7

hsubox76 reviewed Apr 18, 2022

View reviewed changes

repo-scripts/size-analysis/bundle-definitions/functions.json Outdated Show resolved Hide resolved

Force revert functions.json

24e82d0

hsubox76 approved these changes Apr 19, 2022

View reviewed changes

inlined merged commit c69c689 into master Apr 19, 2022

inlined deleted the inlined.callable-url branch April 19, 2022 20:32

hsubox76 mentioned this pull request Apr 25, 2022

Change functions bump to minor #6177

Merged

google-oss-bot mentioned this pull request Apr 27, 2022

Version Packages #6190

Merged

firebase locked and limited conversation to collaborators May 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add httpsCallableFromURL #6162

Add httpsCallableFromURL #6162

inlined commented Apr 16, 2022

changeset-bot bot commented Apr 16, 2022 •

edited

Loading

github-actions bot commented Apr 16, 2022 •

edited

Loading

google-oss-bot commented Apr 16, 2022 •

edited

Loading

`@firebase/functions`

`@firebase/functions-compat`

`bundle`

`firebase`

google-oss-bot commented Apr 16, 2022 •

edited

Loading

`@firebase/functions`

`httpsCallable`

`httpsCallableFromURL`

hsubox76 left a comment

hsubox76 Apr 18, 2022

hsubox76 Apr 18, 2022

hsubox76 Apr 18, 2022

hsubox76 Apr 18, 2022

hsubox76 Apr 18, 2022

inlined Apr 18, 2022

hsubox76 Apr 18, 2022

inlined Apr 18, 2022

hsubox76 left a comment

@@ @@ -29,4 +29,4 @@ @@
                     }
                   ]
                 }
-              ]
+              ]

		@@ -122,7 +122,24 @@ async function callFunctions(app) {
		const callTest = httpsCallable(functions, 'callTest');

Add httpsCallableFromURL #6162

Add httpsCallableFromURL #6162

Conversation

inlined commented Apr 16, 2022

changeset-bot bot commented Apr 16, 2022 • edited Loading

🦋 Changeset detected

github-actions bot commented Apr 16, 2022 • edited Loading

Changeset File Check ✅

google-oss-bot commented Apr 16, 2022 • edited Loading

Size Report 1

Affected Products

@firebase/functions

@firebase/functions-compat

bundle

firebase

Test Logs

google-oss-bot commented Apr 16, 2022 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/functions

httpsCallable

httpsCallableFromURL

Test Logs

hsubox76 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hsubox76 left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Apr 16, 2022 •

edited

Loading

github-actions bot commented Apr 16, 2022 •

edited

Loading

google-oss-bot commented Apr 16, 2022 •

edited

Loading

Size Report ¹

`@firebase/functions`

`@firebase/functions-compat`

`bundle`

`firebase`

google-oss-bot commented Apr 16, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/functions`

`httpsCallable`

`httpsCallableFromURL`