[Auth] Add integration tests (headless & webdriver) for middleware #6161
Conversation
|
| use(chaiAsPromised); | ||
| use(sinonChai); | ||
|
|
||
| export function generateMiddlewareTests(authGetter: () => Auth, signIn: () => Promise<unknown>): void { |
There was a problem hiding this comment.
@jamesdaniels I tried to be exhaustive with these tests. Please take a look and see if I'm missing any big use case.
Cross-tab testing is done down in the webdriver/* files.
I'll add the onAbort callback to the tests once that's merged
Size Report 1Affected ProductsNo changes between base commit (91406c5) and merge commit (68e04c5).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (91406c5) and merge commit (68e04c5).Test Logs |
| @@ -70,6 +75,26 @@ browserDescribe('WebDriver redirect IdP test', driver => { | |||
| expect(await driver.call(RedirectFunction.REDIRECT_RESULT)).to.be.null; | |||
| }); | |||
|
|
|||
| // Redirect works with middleware for now | |||
| xit('is blocked by middleware', async () => { | |||
There was a problem hiding this comment.
Is this temporarily being skipped because it's not implemented yet?
There was a problem hiding this comment.
Yep, I'll switch it to it once that part is working
|
I'm gonna go ahead and submit this. @jamesdaniels if you see anything I need to add later give me a heads up after |
|
@sam-gc SGTM, I'll do some testing next week. |
…6161) * Add integration tests for auth middleware * Webdriver tests * Lint * Formatting
No description provided.