Skip to content

Misc fixes for indexing #6157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Misc fixes for indexing #6157

merged 2 commits into from
Apr 19, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Apr 14, 2022

Backporting from iOS.

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2022

⚠️ No Changeset found

Latest commit: 094c8eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2022

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2022

Size Report 1

Affected Products

  • @firebase/app-check

    TypeBase (7b58dab)Merge (6169af8)Diff
    browser25.2 kB25.2 kB-10 B (-0.0%)
    esm529.8 kB29.8 kB-10 B (-0.0%)
    main31.0 kB31.0 kB-10 B (-0.0%)
    module25.2 kB25.2 kB-10 B (-0.0%)
  • @firebase/firestore

    TypeBase (7b58dab)Merge (6169af8)Diff
    browser252 kB252 kB+4 B (+0.0%)
    esm5313 kB313 kB+4 B (+0.0%)
    main504 kB504 kB+28 B (+0.0%)
    module252 kB252 kB+4 B (+0.0%)
    react-native252 kB252 kB+4 B (+0.0%)
  • bundle

    TypeBase (7b58dab)Merge (6169af8)Diff
    app-check (CustomProvider)33.7 kB33.7 kB-15 B (-0.0%)
    app-check (ReCaptchaEnterpriseProvider)35.9 kB35.9 kB-15 B (-0.0%)
    app-check (ReCaptchaV3Provider)35.9 kB35.8 kB-10 B (-0.0%)
    firestore (Persistence)262 kB262 kB+4 B (+0.0%)
  • firebase

    TypeBase (7b58dab)Merge (6169af8)Diff
    firebase-app-check-compat.js22.7 kB22.7 kB-10 B (-0.0%)
    firebase-app-check.js90.1 kB90.0 kB-10 B (-0.0%)
    firebase-compat.js779 kB779 kB-6 B (-0.0%)
    firebase-firestore-compat.js304 kB304 kB+4 B (+0.0%)
    firebase-firestore.js822 kB822 kB+7 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IHYEwSyoBR.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2022

Size Analysis Report 1

Affected Products

  • @firebase/app-check

    • ReCaptchaEnterpriseProvider

      Size

      TypeBase (7b58dab)Merge (6169af8)Diff
      size10.9 kB10.9 kB-15 B (-0.1%)
      size-with-ext-deps26.6 kB26.5 kB-15 B (-0.1%)
    • ReCaptchaV3Provider

      Size

      TypeBase (7b58dab)Merge (6169af8)Diff
      size10.9 kB10.9 kB-10 B (-0.1%)
      size-with-ext-deps26.5 kB26.5 kB-10 B (-0.0%)
    • initializeAppCheck

      Size

      TypeBase (7b58dab)Merge (6169af8)Diff
      size11.0 kB11.0 kB-15 B (-0.1%)
      size-with-ext-deps26.8 kB26.8 kB-15 B (-0.1%)
  • @firebase/firestore

    • enableIndexedDbPersistence

      Size

      TypeBase (7b58dab)Merge (6169af8)Diff
      size165 kB165 kB+4 B (+0.0%)
      size-with-ext-deps224 kB224 kB+4 B (+0.0%)
    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (7b58dab)Merge (6169af8)Diff
      size197 kB197 kB+4 B (+0.0%)
      size-with-ext-deps256 kB256 kB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BM0Qgs85c9.html

@wu-hui wu-hui merged commit b538312 into master Apr 19, 2022
@wu-hui wu-hui deleted the mrschmidt/fixes branch April 19, 2022 13:14
@firebase firebase locked and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants