Fix the ordering of the index-based lookup in getAll(keys) #6128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7c28b16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (127,563 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
…k into mrschmidt/rdcbug
wu-hui
requested changes
Apr 11, 2022
| } | ||
| } | ||
|
|
||
| return ( |
There was a problem hiding this comment.
primitiveComparator returns number, not boolean..how this works is not obvious to me..
Can we make it more explicit?
There was a problem hiding this comment.
JS compares by "thruhiness" and any non-null number is considered true. We could have something like:
let cmp = compare()
if (cmp) return cmp;
cmp = compare()
if (cmp) return cmp;
cmp = compare()
if (cmp) return cmp;
That was my original code but it is pretty bloated. Let me know what you prefer.
| } | ||
| } | ||
|
|
||
| return ( |
There was a problem hiding this comment.
JS compares by "thruhiness" and any non-null number is considered true. We could have something like:
let cmp = compare()
if (cmp) return cmp;
cmp = compare()
if (cmp) return cmp;
cmp = compare()
if (cmp) return cmp;
That was my original code but it is pretty bloated. Let me know what you prefer.
wu-hui
approved these changes
Apr 12, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the ordering we user for multi-key lookups to match that of IndexedDB.
Fixes #6110