Skip to content

Limit size of heartbeat header #5940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Limit size of heartbeat header #5940

wants to merge 2 commits into from

Conversation

hsubox76
Copy link
Contributor

Limit size of heartbeat header sent (based on the stringified and base64 encoded size).

If the total size of the heartbeats array is more than header size limit, try to send as many heartbeat objects as fit under the limit and keep the rest in cache to send in a future request.

If even the first heartbeat is too large to send, split it into two objects, which each have a piece of the dates array, and send the oldest.

@hsubox76 hsubox76 requested a review from Feiyang1 as a code owner January 27, 2022 01:01
@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2022

⚠️ No Changeset found

Latest commit: c8f8715

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 removed the request for review from Feiyang1 January 27, 2022 20:49
@hsubox76
Copy link
Contributor Author

Closed in favor of #5945

@hsubox76 hsubox76 closed this Jan 27, 2022
@firebase firebase locked and limited conversation to collaborators Feb 27, 2022
@hsubox76 hsubox76 deleted the ch-hb-limit branch June 8, 2022 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant