Skip to content

Add changeset for PR #5739 #5927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Add changeset for PR #5739 #5927

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b32caa
ch-rn-asyncstorage
hsubox76 Jan 25, 2022
3a24ff6
revert
hsubox76 Jan 25, 2022
d3bd3c1
Fix text
hsubox76 Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/yellow-suns-clean.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@firebase/auth': patch
---

Prevent React Native logging a warning about deprecation of `AsyncStorage` if user has provided the non-deprecated version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preposition could clarify a little: "Prevent React Native from logging..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "user" definitely the right term? Or could it be "the developer" or even "the package.json file" or wherever this is defined?

I clearly do not know :) But if we go with this, I'd suggest "if the user"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"developer" makes sense.