Add explicit tests for Compat #5870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -0,0 +1,18 @@ | |||
| <component name="ProjectRunConfigurationManager"> | |||
There was a problem hiding this comment.
New IntelliJ test runner, inspired by the existing runner for Firestore.
| @@ -0,0 +1,18 @@ | |||
| /** | |||
| @@ -0,0 +1,7 @@ | |||
| { | |||
| @@ -0,0 +1,240 @@ | |||
| /** | |||
| @@ -0,0 +1,378 @@ | |||
| /** | |||
| * @license | |||
| @@ -0,0 +1,82 @@ | |||
| /** | |||
| * @license | |||
| * Copyright 2022 Google LLC | |||
There was a problem hiding this comment.
Mostly copied
| * limitations under the License. | ||
| */ | ||
|
|
||
| import * as firestore from '@firebase/firestore-types'; |
| * limitations under the License. | ||
| */ | ||
|
|
||
| export interface Resolver<R> { |
| * limitations under the License. | ||
| */ | ||
|
|
||
| import * as firestore from '@firebase/firestore-types'; |
There was a problem hiding this comment.
Mostly copied
| @@ -0,0 +1,1425 @@ | |||
| /** | |||
| * @license | |||
Size Report 1Affected ProductsNo changes between base commit (f873ad4) and merge commit (fc5b806).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (f873ad4) and merge commit (fc5b806).Test Logs |
hsubox76
approved these changes
Jan 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds explicit integration tests for Firestore Compat, as I am rewriting the existing integration tests to use the v9 API. Most of the files are just copied. Exceptions are noted.