Skip to content

[Auth] Fix persistence selection in compatibility layer in worker scripts #5811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2021
Merged

[Auth] Fix persistence selection in compatibility layer in worker scripts #5811

merged 2 commits into from
Dec 10, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Dec 10, 2021

Fixes #5791

@sam-gc sam-gc requested a review from lisajian December 10, 2021 00:06
@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 02778cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth-compat Patch
@firebase/auth Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sam-gc sam-gc requested a review from egilmorez as a code owner December 10, 2021 00:07
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 10, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/auth-compat

    Type Base (fd8cd3e) Head (abb89de) Diff
    browser 19.8 kB 20.0 kB +262 B (+1.3%)
    esm5 26.6 kB 26.9 kB +260 B (+1.0%)
    main 29.1 kB 29.4 kB +282 B (+1.0%)
    module 19.8 kB 20.0 kB +262 B (+1.3%)

  • firebase

    Type Base (fd8cd3e) Head (abb89de) Diff
    firebase-auth-compat.js 123 kB 123 kB +102 B (+0.1%)
    firebase-compat.js 753 kB 753 kB +102 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 10, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (fd8cd3e) and head commit (abb89de).

@sam-gc sam-gc merged commit e3a5248 into master Dec 10, 2021
@sam-gc sam-gc deleted the sam-gc/persistence-webworker branch December 10, 2021 16:36
@google-oss-bot google-oss-bot mentioned this pull request Jan 5, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lisajian lisajian lisajian approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@lisajian lisajian

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firebase 9.6 in web worker: auth.onAuthStateChanged called once, user always null
4 participants
@sam-gc @google-oss-bot @lisajian @yuchenshi