Skip to content

Verify OIDC/SAML sign in against Auth Emulator #5776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Conversation

lisajian
Copy link
Contributor

@lisajian lisajian commented Dec 1, 2021

Discussion

  • Add TODO for unused custom parameters
  • Uncommented logic for sign in with SAML providers

Corresponding internal bug: b/192387796

Testing

Verified that OIDC/SAML happy cases work against head of Auth Emulator mainline. Followed instructions for running against emulator (here). See videos of sign in flows:

API Changes

N/A

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2021

⚠️ No Changeset found

Latest commit: 9d38a9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Dec 1, 2021
@lisajian lisajian marked this pull request as ready for review December 1, 2021 20:42
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 1, 2021

Binary Size Report

Affected SDKs

No changes between base commit (dc6b447) and head commit (c5c8c8b).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 1, 2021

Size Analysis Report

Affected Products

No changes between base commit (dc6b447) and head commit (c5c8c8b).

@lisajian lisajian merged commit bdc71d1 into master Dec 2, 2021
@lisajian lisajian deleted the lj-oidc-saml branch December 2, 2021 18:48
@firebase firebase locked and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants