Skip to content

[bundle-size][database] Refine bundle definition #5772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2021
Merged

[bundle-size][database] Refine bundle definition #5772

merged 2 commits into from
Dec 4, 2021

Conversation

yifanyang
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: f60db90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Dec 1, 2021
@yifanyang yifanyang changed the title [bundle-size] Refine bundle definition for Database [bundle-size][database] Refine bundle definition Dec 1, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 1, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • bundle

    Type Base (6ae54d0) Head (72fa76e) Diff
    database (Listen for value events + Detach listeners) ? 152 kB ? (?)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 1, 2021 •
edited
Loading

Size Analysis Report

Affected Products

Diffs between base commit (6ae54d0) and head commit (72fa76e) are too large (1,138,758 characters) to display.

Please check below links to see details from the original test log.

schmidt-sebastian
schmidt-sebastian reviewed Dec 2, 2021
View reviewed changes
repo-scripts/size-analysis/bundle-definitions/database.json Outdated
@@ -151,7 +151,8 @@
"ref",
"onChildAdded",
"onChildChanged",
"onChildRemoved"
"onChildRemoved",
"off"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add another definition that just uses getDatabase+ref+onValue+off? off is probably not used by most users, so I don't want to make it the default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Made it a separate test case now.

p.s. I had to force push the new change which is rebased onto a more recent commit on master branch. This is to let the diff report to pick the right comparison target commit. See here for more detail.

@yifanyang yifanyang force-pushed the yifany/bundle-database branch from 384f663 to f60db90 Compare December 3, 2021 00:07
@yifanyang yifanyang merged commit 8d04184 into master Dec 4, 2021
@yifanyang yifanyang deleted the yifany/bundle-database branch December 4, 2021 00:44
@firebase firebase locked and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yifanyang @google-oss-bot @Feiyang1 @schmidt-sebastian