fix firestore node tests #5741
Merged
fix firestore node tests #5741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi, @hsubox76 |
🦋 Changeset detectedLatest commit: 623ede6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs |
There was a problem hiding this comment.
I tried to use this via the IntelliJ test runner but it failed with the following error:
✖ ERROR: /Users/mrschmidt/GitHub/firebase/firebase-js-sdk/packages/firestore/test/register.ts:18
import firebase from '@firebase/app-compat';
^^^^^^
SyntaxError: Cannot use import statement outside a module
The diff for the change:
https://paste.googleplex.com/6380219926577152
We really need to find a way to make Firestore run via ts-node, as this allows us to debug in the IDE.
|
@schmidt-sebastian |
|
No, I am not able to. I will play around with this some more (but not sure if I can get to it today) |
schmidt-sebastian
approved these changes
Nov 23, 2021
hsubox76
approved these changes
Nov 29, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use babel to compile tests for Node testing, so that
import.meta.urlcan be compiled correctly.