clear the global timeout once an operation is done in the Storage SDK #5703

Feiyang1 · 2021-11-05T00:02:41Z

changeset-bot · 2021-11-05T00:02:43Z

🦋 Changeset detected

Latest commit: 1265a79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/storage	Patch
firebase	Patch
@firebase/storage-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2021-11-05T00:22:37Z

Binary Size Report

Affected SDKs

`@firebase/storage`

Type	Base (`dbd54f7`)	Head (`45c4365`)	Diff
browser	52.1 kB	52.4 kB	+231 B (+0.4%)
esm5	57.5 kB	57.8 kB	+231 B (+0.4%)
main	53.7 kB	54.0 kB	+231 B (+0.4%)
module	52.1 kB	52.4 kB	+231 B (+0.4%)

`firebase`

Type	Base (`dbd54f7`)	Head (`45c4365`)	Diff
firebase-compat.js	749 kB	749 kB	+75 B (+0.0%)
firebase-storage-compat.js	38.0 kB	38.1 kB	+75 B (+0.2%)
firebase-storage.js	139 kB	140 kB	+411 B (+0.3%)

Test Logs

Base (dbd54f7c): https://github.com/firebase/firebase-js-sdk/actions/runs/1423262838
Head (45c43655): https://github.com/firebase/firebase-js-sdk/actions/runs/1427022050

google-oss-bot · 2021-11-05T00:49:38Z

Size Analysis Report

Affected Products

@firebase/storage
- _FbsBlob
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  13.9 kB
  13.9 kB
  +65 B (+0.5%)
  size-with-ext-deps
  19.8 kB
  19.9 kB
  +65 B (+0.3%)
- _Location
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  9.90 kB
  9.96 kB
  +65 B (+0.7%)
  size-with-ext-deps
  15.8 kB
  15.9 kB
  +65 B (+0.4%)
- _UploadTask
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  28.7 kB
  28.8 kB
  +65 B (+0.2%)
  size-with-ext-deps
  34.7 kB
  34.7 kB
  +65 B (+0.2%)
- _dataFromString
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  12.1 kB
  12.2 kB
  +65 B (+0.5%)
  size-with-ext-deps
  18.1 kB
  18.1 kB
  +65 B (+0.4%)
- _getChild
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  10.2 kB
  10.2 kB
  +65 B (+0.6%)
  size-with-ext-deps
  16.1 kB
  16.1 kB
  +65 B (+0.4%)
- _invalidArgument
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  9.91 kB
  9.97 kB
  +65 B (+0.7%)
  size-with-ext-deps
  15.8 kB
  15.9 kB
  +65 B (+0.4%)
- _invalidRootOperation
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  9.91 kB
  9.98 kB
  +65 B (+0.7%)
  size-with-ext-deps
  15.8 kB
  15.9 kB
  +65 B (+0.4%)
- connectStorageEmulator
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  10.1 kB
  10.2 kB
  +65 B (+0.6%)
  size-with-ext-deps
  19.7 kB
  19.8 kB
  +65 B (+0.3%)
- deleteObject
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  13.0 kB
  13.1 kB
  +65 B (+0.5%)
  size-with-ext-deps
  19.0 kB
  19.1 kB
  +65 B (+0.3%)
- getDownloadURL
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  15.2 kB
  15.3 kB
  +65 B (+0.4%)
  size-with-ext-deps
  21.2 kB
  21.3 kB
  +65 B (+0.3%)
- getMetadata
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  14.6 kB
  14.7 kB
  +65 B (+0.4%)
  size-with-ext-deps
  20.6 kB
  20.7 kB
  +65 B (+0.3%)
- getStorage
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  10.0 kB
  10.1 kB
  +65 B (+0.6%)
  size-with-ext-deps
  16.2 kB
  16.2 kB
  +65 B (+0.4%)
- list
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  13.8 kB
  13.8 kB
  +65 B (+0.5%)
  size-with-ext-deps
  19.8 kB
  19.8 kB
  +65 B (+0.3%)
- listAll
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  14.0 kB
  14.1 kB
  +65 B (+0.5%)
  size-with-ext-deps
  20.0 kB
  20.1 kB
  +65 B (+0.3%)
- ref
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  10.8 kB
  10.8 kB
  +65 B (+0.6%)
  size-with-ext-deps
  16.7 kB
  16.8 kB
  +65 B (+0.4%)
- updateMetadata
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  14.9 kB
  15.0 kB
  +65 B (+0.4%)
  size-with-ext-deps
  20.9 kB
  21.0 kB
  +65 B (+0.3%)
- uploadBytes
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  19.4 kB
  19.5 kB
  +65 B (+0.3%)
  size-with-ext-deps
  25.5 kB
  25.5 kB
  +65 B (+0.3%)
- uploadBytesResumable
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  28.9 kB
  28.9 kB
  +65 B (+0.2%)
  size-with-ext-deps
  34.9 kB
  34.9 kB
  +65 B (+0.2%)
- uploadString
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  19.6 kB
  19.7 kB
  +65 B (+0.3%)
  size-with-ext-deps
  25.7 kB
  25.7 kB
  +65 B (+0.3%)
- StringFormat
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  9.98 kB
  10.0 kB
  +65 B (+0.7%)
  size-with-ext-deps
  15.9 kB
  16.0 kB
  +65 B (+0.4%)
- _TaskEvent
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  9.94 kB
  10.0 kB
  +65 B (+0.7%)
  size-with-ext-deps
  15.9 kB
  15.9 kB
  +65 B (+0.4%)
- _TaskState
  Size Table
  Type Base (dbd54f7) Head (209d417) Diff
  size
  10.0 kB
  10.1 kB
  +65 B (+0.7%)
  size-with-ext-deps
  15.9 kB
  16.0 kB
  +65 B (+0.4%)

Test Logs

packages/storage/src/implementation/backoff.ts

clear the global timeout once an operation is done

e3386a1

Feiyang1 requested a review from schmidt-sebastian as a code owner November 5, 2021 00:02

Feiyang1 assigned schmidt-sebastian Nov 5, 2021

google-cla bot added the cla: yes label Nov 5, 2021

Create tame-beans-study.md

1733c64

Feiyang1 requested a review from egilmorez as a code owner November 5, 2021 00:04

schmidt-sebastian reviewed Nov 5, 2021

View reviewed changes

packages/storage/src/implementation/backoff.ts Outdated Show resolved Hide resolved

schmidt-sebastian approved these changes Nov 5, 2021

View reviewed changes

schmidt-sebastian assigned Feiyang1 and unassigned schmidt-sebastian Nov 5, 2021

format

1265a79

Feiyang1 merged commit e0fe2b6 into master Nov 10, 2021

Feiyang1 deleted the fei-storage-hang branch November 10, 2021 18:00

google-oss-bot mentioned this pull request Nov 10, 2021

Version Packages #5718

Merged

firebase locked and limited conversation to collaborators Dec 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

clear the global timeout once an operation is done in the Storage SDK #5703

clear the global timeout once an operation is done in the Storage SDK #5703

Feiyang1 commented Nov 5, 2021

changeset-bot bot commented Nov 5, 2021 •

edited

Loading

google-oss-bot commented Nov 5, 2021 •

edited

Loading

`@firebase/storage`

`firebase`

google-oss-bot commented Nov 5, 2021 •

edited

Loading

Affected Products

`@firebase/storage`

`_FbsBlob`

`_Location`

`_UploadTask`

`_dataFromString`

`_getChild`

`_invalidArgument`

`_invalidRootOperation`

`connectStorageEmulator`

`deleteObject`

`getDownloadURL`

`getMetadata`

`getStorage`

`list`

`listAll`

`ref`

`updateMetadata`

`uploadBytes`

`uploadBytesResumable`

`uploadString`

`StringFormat`

`_TaskEvent`

`_TaskState`

Test Logs

clear the global timeout once an operation is done in the Storage SDK #5703

clear the global timeout once an operation is done in the Storage SDK #5703

Conversation

Feiyang1 commented Nov 5, 2021

changeset-bot bot commented Nov 5, 2021 • edited Loading

🦋 Changeset detected

google-oss-bot commented Nov 5, 2021 • edited Loading

Binary Size Report

Affected SDKs

@firebase/storage

firebase

Test Logs

google-oss-bot commented Nov 5, 2021 • edited Loading

Size Analysis Report

Affected Products

@firebase/storage

_FbsBlob

_Location

_UploadTask

_dataFromString

_getChild

_invalidArgument

_invalidRootOperation

connectStorageEmulator

deleteObject

getDownloadURL

getMetadata

getStorage

list

listAll

ref

updateMetadata

uploadBytes

uploadBytesResumable

uploadString

StringFormat

_TaskEvent

_TaskState

Test Logs

changeset-bot bot commented Nov 5, 2021 •

edited

Loading

google-oss-bot commented Nov 5, 2021 •

edited

Loading

`@firebase/storage`

`firebase`

google-oss-bot commented Nov 5, 2021 •

edited

Loading

`@firebase/storage`

`_FbsBlob`

`_Location`

`_UploadTask`

`_dataFromString`

`_getChild`

`_invalidArgument`

`_invalidRootOperation`

`connectStorageEmulator`

`deleteObject`

`getDownloadURL`

`getMetadata`

`getStorage`

`list`

`listAll`

`ref`

`updateMetadata`

`uploadBytes`

`uploadBytesResumable`

`uploadString`

`StringFormat`

`_TaskEvent`

`_TaskState`