Skip to content

Fix rollup config for compatibility layer builds #5664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 26, 2021
Merged

Fix rollup config for compatibility layer builds #5664

merged 4 commits into from
Oct 26, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Oct 25, 2021

Fixes #5644

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: de5f274

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Oct 25, 2021
@sam-gc sam-gc requested a review from egilmorez as a code owner October 25, 2021 21:45
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 25, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase

    Click to show 13 binary size changes.
    Type Base (2e7586d) Head (4c82460) Diff
    firebase-analytics-compat.js 26.0 kB 26.1 kB +91 B (+0.3%)
    firebase-app-check-compat.js 19.9 kB 20.0 kB +58 B (+0.3%)
    firebase-app-compat.js 21.3 kB 21.3 kB +12 B (+0.1%)
    firebase-auth-compat.js 122 kB 122 kB +323 B (+0.3%)
    firebase-compat.js 749 kB 751 kB +1.76 kB (+0.2%)
    firebase-database-compat.js 168 kB 169 kB +482 B (+0.3%)
    firebase-firestore-compat.js 277 kB 278 kB +629 B (+0.2%)
    firebase-functions-compat.js 7.94 kB 7.95 kB +10 B (+0.1%)
    firebase-messaging-compat.js 37.9 kB 38.0 kB +105 B (+0.3%)
    firebase-performance-compat.js 30.8 kB 30.9 kB +72 B (+0.2%)
    firebase-performance-standalone-compat.js 54.0 kB 54.0 kB +68 B (+0.1%)
    firebase-remote-config-compat.js 27.5 kB 27.6 kB +52 B (+0.2%)
    firebase-storage-compat.js 38.2 kB 38.2 kB +42 B (+0.1%)

Test Logs

hsubox76
hsubox76 reviewed Oct 25, 2021
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verified that it generates the correct output?
  • There's a formatting check failure, run yarn format

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 25, 2021 •
edited
Loading

Size Analysis Report

Affected Products

Diffs between base commit (2e7586d) and head commit (4c82460) are too large (1,122,347 characters) to display.

Please check below links to see details from the original test log.

@sam-gc
Copy link
Contributor Author

sam-gc commented Oct 25, 2021

Yep, verified that it generates correct output; tested against the auth demo

@sam-gc sam-gc merged commit f0f6d74 into master Oct 26, 2021
@sam-gc sam-gc deleted the sam-gc/wk branch October 26, 2021 03:06
@google-oss-bot google-oss-bot mentioned this pull request Oct 27, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@hsubox76 hsubox76

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with version 9 compat build on Safari after one hour long sessions
3 participants
@sam-gc @google-oss-bot @hsubox76