Skip to content

Fix formatting in Storage. #5645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2021
Merged

Fix formatting in Storage. #5645

merged 3 commits into from
Oct 20, 2021

Conversation

ehsannas
Copy link
Contributor

Ran yarn prettier. This is needed to unblock other PRs.

@ehsannas
Fix formatting in Storage.
0139bad 
Ran `yarn prettier`. This will unblock other PRs.
@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: fee05a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Oct 20, 2021
@ehsannas ehsannas requested a review from egilmorez as a code owner October 20, 2021 21:44
schmidt-sebastian
schmidt-sebastian approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks (I think this managed to slip through because the person that made those changes had not synced master into his repo(*))

(*) whoever that person might be. cough cough.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 20, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (f1c38f3) and head commit (44c50db).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 20, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (f1c38f3) and head commit (44c50db).

@ehsannas ehsannas merged commit 65dce18 into master Oct 20, 2021
@ehsannas ehsannas deleted the ehsann/fix-storage-formatting branch October 20, 2021 23:25
@firebase firebase locked and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@ehsannas ehsannas

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @schmidt-sebastian