Disable Fetch for ReactNative #5643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d1d3f28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -20,7 +20,7 @@ | |||
| "dev": "rollup -c -w", | |||
| "lint": "eslint -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'", | |||
| "lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'", | |||
| "prettier": "prettier --write '*.js' '*.ts' '@(lite|src|test)/**/*.ts'", | |||
| "prettier": "prettier --write '*.js' '@(lite|src|test)/**/*.ts'", | |||
There was a problem hiding this comment.
Prettier fails since there are no *.ts files at the root anymore.
Binary Size ReportAffected SDKs
Test Logs |
Feiyang1
approved these changes
Oct 20, 2021
Merged
Merged
Is the comment incorrect? Should it say |
|
Yeah, it should be the other way around. Let me fix the discription. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to use XHR instead of Fetch for ReactNative since
response.blobis not supported (see facebook/react-native#27741)Addresses #1674