Skip to content

[Auth] Add aria-hidden='true' attribute to embedded iframe #5633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2021
Merged

[Auth] Add aria-hidden='true' attribute to embedded iframe #5633

merged 2 commits into from
Oct 18, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Oct 18, 2021

Fixes #5631

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: f53a226

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Oct 18, 2021
@sam-gc sam-gc requested a review from egilmorez as a code owner October 18, 2021 19:11
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 18, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/auth/internal

    Type Base (abb3b3d) Head (691ac2b) Diff
    browser 163 kB 163 kB +21 B (+0.0%)
    esm5 211 kB 211 kB +21 B (+0.0%)
    module 163 kB 163 kB +21 B (+0.0%)

  • firebase

    Type Base (abb3b3d) Head (691ac2b) Diff
    firebase-auth-compat.js 122 kB 122 kB +21 B (+0.0%)
    firebase-auth.js 410 kB 410 kB +28 B (+0.0%)
    firebase-compat.js 749 kB 749 kB +21 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 18, 2021 •
edited
Loading

Size Analysis Report

Affected Products

  • @firebase/auth

    • getAuth

      Size Table

      TypeBase (abb3b3d)Head (691ac2b)Diff
      size
      61.6 kB
      61.6 kB
      +21 B (+0.0%)
      size-with-ext-deps
      74.1 kB
      74.1 kB
      +21 B (+0.0%)

    • browserPopupRedirectResolver

      Size Table

      TypeBase (abb3b3d)Head (691ac2b)Diff
      size
      53.9 kB
      53.9 kB
      +21 B (+0.0%)
      size-with-ext-deps
      65.9 kB
      66.0 kB
      +21 B (+0.0%)

@sam-gc sam-gc merged commit 2429ac1 into master Oct 18, 2021
@sam-gc sam-gc deleted the sam-gc/iframe-aria branch October 18, 2021 21:27
This was referenced Oct 19, 2021
Merged
Merged
@firebase firebase locked and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avolkovi avolkovi avolkovi approved these changes

@lisajian lisajian lisajian approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@lisajian lisajian

@yuchenshi yuchenshi

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lighthouse Report Issue with auth iframe
5 participants
@sam-gc @google-oss-bot @avolkovi @lisajian @yuchenshi