Add Healthy state to streams. #5622

ehsannas · 2021-10-15T17:02:30Z

No description provided.

changeset-bot · 2021-10-15T17:02:33Z

⚠️ No Changeset found

Latest commit: 5461e28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

packages/firestore/CHANGELOG.md

google-oss-bot · 2021-10-15T17:23:01Z

Binary Size Report

Affected SDKs

`@firebase/firestore`

Type	Base (`ba40cde`)	Head (`15e5a9b`)	Diff
browser	225 kB	225 kB	+253 B (+0.1%)
esm5	282 kB	282 kB	+273 B (+0.1%)
main	512 kB	513 kB	+488 B (+0.1%)
module	225 kB	225 kB	+253 B (+0.1%)
react-native	225 kB	225 kB	+253 B (+0.1%)

`firebase`

Type	Base (`ba40cde`)	Head (`15e5a9b`)	Diff
firebase-compat.js	749 kB	749 kB	+251 B (+0.0%)
firebase-firestore-compat.js	277 kB	277 kB	+251 B (+0.1%)
firebase-firestore.js	762 kB	763 kB	+792 B (+0.1%)

Test Logs

Base (ba40cde9): https://github.com/firebase/firebase-js-sdk/actions/runs/1343940203
Head (15e5a9b5): https://github.com/firebase/firebase-js-sdk/actions/runs/1347624486

.changeset/fresh-otters-eat.md

packages/firestore/CHANGELOG.md

packages/firestore/src/remote/persistent_stream.ts

google-oss-bot · 2021-10-15T17:41:45Z

Size Analysis Report

Affected Products

@firebase/firestore
- addDoc
  Size Table
  Type Base (ba40cde) Head (15e5a9b) Diff
  size
  103 kB
  103 kB
  +230 B (+0.2%)
  size-with-ext-deps
  152 kB
  152 kB
  +230 B (+0.2%)
- deleteDoc
  Size Table
  Type Base (ba40cde) Head (15e5a9b) Diff
  size
  94.3 kB
  94.5 kB
  +230 B (+0.2%)
  size-with-ext-deps
  143 kB
  143 kB
  +230 B (+0.2%)
- enableIndexedDbPersistence
  Size Table
  Type Base (ba40cde) Head (15e5a9b) Diff
  size
  139 kB
  139 kB
  +230 B (+0.2%)
  size-with-ext-deps
  188 kB
  188 kB
  +230 B (+0.1%)
- enableMultiTabIndexedDbPersistence
  Size Table
  Type Base (ba40cde) Head (15e5a9b) Diff
  size
  170 kB
  171 kB
  +253 B (+0.1%)
  size-with-ext-deps
  220 kB
  220 kB
  +253 B (+0.1%)
- executeWrite
  Size Table
  Type Base (ba40cde) Head (15e5a9b) Diff
  size
  93.4 kB
  93.7 kB
  +230 B (+0.2%)
  size-with-ext-deps
  142 kB
  142 kB
  +230 B (+0.2%)
- getDoc
  Size Table
  Type Base (ba40cde) Head (15e5a9b) Diff
  size
  119 kB
  119 kB
  +230 B (+0.2%)
  size-with-ext-deps
  168 kB
  168 kB
  +230 B (+0.1%)
- getDocFromServer
  Size Table
  Type Base (ba40cde) Head (15e5a9b) Diff
  size
  119 kB
  119 kB
  +230 B (+0.2%)
  size-with-ext-deps
  168 kB
  168 kB
  +230 B (+0.1%)
- getDocs
  Size Table
  Type Base (ba40cde) Head (15e5a9b) Diff
  size
  121 kB
  121 kB
  +230 B (+0.2%)
  size-with-ext-deps
  169 kB
  170 kB
  +230 B (+0.1%)
- getDocsFromServer
  Size Table
  Type Base (ba40cde) Head (15e5a9b) Diff
  size
  121 kB
  121 kB
  +230 B (+0.2%)
  size-with-ext-deps
  169 kB
  169 kB
  +230 B (+0.1%)
- onSnapshot
  Size Table
  Type Base (ba40cde) Head (15e5a9b) Diff
  size
  121 kB
  121 kB
  +230 B (+0.2%)
  size-with-ext-deps
  170 kB
  170 kB
  +230 B (+0.1%)
- onSnapshotsInSync
  Size Table
  Type Base (ba40cde) Head (15e5a9b) Diff
  size
  111 kB
  111 kB
  +230 B (+0.2%)
  size-with-ext-deps
  160 kB
  160 kB
  +230 B (+0.1%)
- setDoc
  Size Table
  Type Base (ba40cde) Head (15e5a9b) Diff
  size
  102 kB
  103 kB
  +230 B (+0.2%)
  size-with-ext-deps
  151 kB
  151 kB
  +230 B (+0.2%)
- updateDoc
  Size Table
  Type Base (ba40cde) Head (15e5a9b) Diff
  size
  103 kB
  103 kB
  +230 B (+0.2%)
  size-with-ext-deps
  152 kB
  152 kB
  +230 B (+0.2%)
- writeBatch
  Size Table
  Type Base (ba40cde) Head (15e5a9b) Diff
  size
  105 kB
  105 kB
  +230 B (+0.2%)
  size-with-ext-deps
  154 kB
  154 kB
  +230 B (+0.1%)

Test Logs

schmidt-sebastian

Requesting changes so I can look at it one final time when the tests are fixed.

packages/firestore/src/remote/persistent_stream.ts

Add Healthy state to streams.

125b6d8

ehsannas requested a review from schmidt-sebastian October 15, 2021 17:02

google-cla bot added the cla: yes label Oct 15, 2021

ehsannas assigned schmidt-sebastian Oct 15, 2021

ehsannas and others added 2 commits October 15, 2021 12:05

Add changelog.

4a8a7df

Create fresh-otters-eat.md

29a0760

ehsannas requested a review from egilmorez as a code owner October 15, 2021 17:08

ehsannas commented Oct 15, 2021

View reviewed changes

packages/firestore/CHANGELOG.md Outdated Show resolved Hide resolved

schmidt-sebastian approved these changes Oct 15, 2021

View reviewed changes

.changeset/fresh-otters-eat.md Outdated Show resolved Hide resolved

packages/firestore/CHANGELOG.md Outdated Show resolved Hide resolved

packages/firestore/src/remote/persistent_stream.ts Outdated Show resolved Hide resolved

schmidt-sebastian assigned ehsannas and unassigned schmidt-sebastian Oct 15, 2021

Remove changelog/changeset.

47b1a26

schmidt-sebastian suggested changes Oct 15, 2021

View reviewed changes

ehsannas added 2 commits October 15, 2021 15:15

Cancel healthCheck in close, not in sendRequest.

e1ce005

Perform everything in dispatchIfNotClosed.

7989d10

ehsannas requested a review from schmidt-sebastian October 15, 2021 21:42

ehsannas assigned schmidt-sebastian and unassigned ehsannas Oct 15, 2021

schmidt-sebastian reviewed Oct 15, 2021

View reviewed changes

packages/firestore/src/remote/persistent_stream.ts Outdated Show resolved Hide resolved

schmidt-sebastian approved these changes Oct 15, 2021

View reviewed changes

perform the healthCheck assignment after checking the stream state.

5461e28

ehsannas merged commit abb3b3d into master Oct 16, 2021

ehsannas deleted the ehsann/add-healthy-state branch October 16, 2021 02:20

firebase locked and limited conversation to collaborators Nov 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Healthy state to streams. #5622

Add Healthy state to streams. #5622

ehsannas commented Oct 15, 2021

changeset-bot bot commented Oct 15, 2021 •

edited

Loading

google-oss-bot commented Oct 15, 2021 •

edited

Loading

`@firebase/firestore`

`firebase`

google-oss-bot commented Oct 15, 2021 •

edited

Loading

Affected Products

`@firebase/firestore`

`addDoc`

`deleteDoc`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`executeWrite`

`getDoc`

`getDocFromServer`

`getDocs`

`getDocsFromServer`

`onSnapshot`

`onSnapshotsInSync`

`setDoc`

`updateDoc`

`writeBatch`

Test Logs

schmidt-sebastian left a comment

Add Healthy state to streams. #5622

Add Healthy state to streams. #5622

Conversation

ehsannas commented Oct 15, 2021

changeset-bot bot commented Oct 15, 2021 • edited Loading

⚠️ No Changeset found

google-oss-bot commented Oct 15, 2021 • edited Loading

Binary Size Report

Affected SDKs

@firebase/firestore

firebase

Test Logs

google-oss-bot commented Oct 15, 2021 • edited Loading

Size Analysis Report

Affected Products

@firebase/firestore

addDoc

deleteDoc

enableIndexedDbPersistence

enableMultiTabIndexedDbPersistence

executeWrite

getDoc

getDocFromServer

getDocs

getDocsFromServer

onSnapshot

onSnapshotsInSync

setDoc

updateDoc

writeBatch

Test Logs

schmidt-sebastian left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Oct 15, 2021 •

edited

Loading

google-oss-bot commented Oct 15, 2021 •

edited

Loading

`@firebase/firestore`

`firebase`

google-oss-bot commented Oct 15, 2021 •

edited

Loading

`@firebase/firestore`

`addDoc`

`deleteDoc`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`executeWrite`

`getDoc`

`getDocFromServer`

`getDocs`

`getDocsFromServer`

`onSnapshot`

`onSnapshotsInSync`

`setDoc`

`updateDoc`

`writeBatch`