Run prettier/license on whole repo #5604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
requested review from
avolkovi,
erikeldridge,
Feiyang1,
hiranya911,
jposuna,
jsdt,
lisajian,
sam-gc,
schmidt-sebastian,
yoyomyo,
yuchenshi and
zwu52
as code owners
|
jposuna
approved these changes
Oct 11, 2021
| @@ -25,7 +25,8 @@ import { FirebasePerformance as FirebasePerformanceCompat } from '@firebase/perf | |||
| import { FirebaseApp, _FirebaseService } from '@firebase/app-compat'; | |||
|
|
|||
| export class PerformanceCompatImpl | |||
| implements FirebasePerformanceCompat, _FirebaseService { | |||
| implements FirebasePerformanceCompat, _FirebaseService | |||
| { | |||
There was a problem hiding this comment.
This seems like a weird indentation; is this expected?
There was a problem hiding this comment.
It is. I'm not sure why but it seems to be a rule when the class declaration is broken into 2 (or more) lines.
Feiyang1
approved these changes
Oct 11, 2021
Size Analysis Report |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catching up on missed formatting before implementing formatting CI check.