Skip to content

Add GHA workflow for submitting tags to metric service. #5602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

yifanyang
Copy link
Contributor

@yifanyang yifanyang commented Oct 11, 2021

Add a GitHub Actions workflow file for submitting the tags information (name, commit sha1) to the SDK metric service.

  • The custom action yifanyang/github-actions/health-metrics/release-diffing is defined here. I intend to have it reused across all Android/Apple/Web SDK repositories. For now, I'm putting it in my personal repository yifanyang/github-actions, but will figure out later where the best location for the code is.
    The action is open sourced at https://github.com/FirebaseExtended/github-actions/tree/master/health-metrics/release-diffing.
  • At the moment, on the metric service end, only the logic of persisting tag information is implemented. Upon submission of this PR, we will be start to see tags stored in the database. I will send out the bundle definitions for you folks to review soon, so that we can associate releases/tags with meaningful metric data.
    The bundle definitions are to be added in Add bundle definitions and its measurement script. #5706.

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2021

⚠️ No Changeset found

Latest commit: 61eb6e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Oct 11, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 11, 2021

Binary Size Report

Affected SDKs

No changes between base commit (882d864) and head commit (8af534d).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 11, 2021

Size Analysis Report

Affected Products

No changes between base commit (882d864) and head commit (8af534d).

@@ -3,7 +3,7 @@ name: Health Metrics
on: [push, pull_request]

env:
METRICS_SERVICE_URL: ${{ secrets.METRICS_SERVICE_URL }}
METRICS_SERVICE_URL: "https://api.firebase-sdk-health-metrics.com"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you removed it in the other PR?

Copy link
Contributor Author

@yifanyang yifanyang Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Once #5706 is merged, I don't know whether I'll need to address the merge conflict here or GitHub is smart enough to handle it. Let's see.

@yifanyang yifanyang force-pushed the yifany/workflow branch 3 times, most recently from c738216 to 480fd63 Compare November 12, 2021 17:34
@yifanyang yifanyang merged commit acc5810 into master Nov 12, 2021
@yifanyang yifanyang deleted the yifany/workflow branch November 12, 2021 23:16
@firebase firebase locked and limited conversation to collaborators Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants