-
Notifications
You must be signed in to change notification settings - Fork 926
Add GHA workflow for submitting tags to metric service. #5602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Analysis Report |
@@ -3,7 +3,7 @@ name: Health Metrics | |||
on: [push, pull_request] | |||
|
|||
env: | |||
METRICS_SERVICE_URL: ${{ secrets.METRICS_SERVICE_URL }} | |||
METRICS_SERVICE_URL: "https://api.firebase-sdk-health-metrics.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you removed it in the other PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Once #5706 is merged, I don't know whether I'll need to address the merge conflict here or GitHub is smart enough to handle it. Let's see.
c738216
to
480fd63
Compare
480fd63
to
61eb6e2
Compare
Add a GitHub Actions workflow file for submitting the tags information (name, commit sha1) to the SDK metric service.
The custom actionyifanyang/github-actions/health-metrics/release-diffing
is defined here. I intend to have it reused across all Android/Apple/Web SDK repositories. For now, I'm putting it in my personal repositoryyifanyang/github-actions
, but will figure out later where the best location for the code is.The action is open sourced at https://github.com/FirebaseExtended/github-actions/tree/master/health-metrics/release-diffing.
At the moment, on the metric service end, only the logic of persisting tag information is implemented. Upon submission of this PR, we will be start to see tags stored in the database. I will send out the bundle definitions for you folks to review soon, so that we can associate releases/tags with meaningful metric data.The bundle definitions are to be added in Add bundle definitions and its measurement script. #5706.