Implement ReCaptchaEnterprise for App Check #5595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 54b258c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs |
hsubox76
requested review from
avolkovi,
erikeldridge,
jposuna,
jsdt,
lisajian,
sam-gc,
schmidt-sebastian,
yoyomyo,
yuchenshi and
zwu52
as code owners
hsubox76
force-pushed
the
ch-recaptcha-enterprise
branch
from
55382f0 to
e5725c2
Compare
hsubox76
changed the title
hsubox76
changed the title
hsubox76
changed the title
Feiyang1
suggested changes
Oct 27, 2021
| export function getFakeGreCAPTCHA(): GreCAPTCHA { | ||
| return { | ||
| export function getFakeGreCAPTCHA( | ||
| isTopLevel: boolean = true |
There was a problem hiding this comment.
The grecaptcha enterprise object is a nested copy of grecaptcha (see the types in recaptcha.ts lines 185 and 189) in a property with the key enterprise. To create a fake grecaptcha object, it recursively calls itself once to put a copy of itself inside the enterprise property with all the same keys except enterprise. Should I put a comment here or where the types are defined in recaptcha.ts?
There was a problem hiding this comment.
A comment to explain what this flag does would be helpful
Co-authored-by: Feiyang <[email protected]>
hsubox76
commented
Oct 28, 2021
| @@ -1551,6 +1551,15 @@ declare namespace firebase.appCheck { | |||
| */ | |||
There was a problem hiding this comment.
@kevinthecheung This file is a documentation source.
hsubox76
commented
Oct 28, 2021
| @@ -88,6 +83,61 @@ export class ReCaptchaV3Provider implements AppCheckProvider { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * App Check provider that can obtain a reCAPTCHA Enterprise token and exchange it | |||
There was a problem hiding this comment.
@kevinthecheung This comment will go into documentation.
hsubox76
commented
Oct 28, 2021
kevinthecheung
approved these changes
Oct 28, 2021
Feiyang1
approved these changes
Oct 29, 2021
weixifan
reviewed
Nov 1, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ReCaptchaEnterpriseProviderand associated methods toapp-checkandapp-check-compat.E2E tests were successful.
We want to coordinate the release with iOS/Android, do not merge until the coordinated date (TBD).