Skip to content

Fix compat docs paths #5594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2021
Merged

Fix compat docs paths #5594

merged 1 commit into from
Oct 11, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Oct 8, 2021

Add "v8" subdir to compat docs paths.

@changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2021

⚠️ No Changeset found

Latest commit: ddd384a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Oct 8, 2021
@hsubox76 hsubox76 requested a review from egilmorez October 8, 2021 19:03
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (53a9263) and head commit (af0c212).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (53a9263) and head commit (af0c212).

@Feiyang1 Feiyang1 assigned hsubox76 and unassigned Feiyang1 Oct 11, 2021
@hsubox76 hsubox76 merged commit 8c6b2ca into master Oct 11, 2021
@hsubox76 hsubox76 deleted the ch-v8-toc branch October 11, 2021 17:25
egilmorez
egilmorez reviewed Oct 11, 2021
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@firebase firebase locked and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@egilmorez egilmorez egilmorez left review comments

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@egilmorez egilmorez

@hsubox76 hsubox76

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsubox76 @google-oss-bot @Feiyang1 @egilmorez