Skip to content

[Auth] Fix incorrectly-cased parameter in OOB request #5542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2021
Merged

[Auth] Fix incorrectly-cased parameter in OOB request #5542

merged 3 commits into from
Sep 27, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Sep 24, 2021

Fixes #5541

We were sending iosBundleId instead of iOSBundleId, which was causing incorrect behavior.

@sam-gc sam-gc requested a review from yuchenshi September 24, 2021 23:01
@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 00fc787

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Sep 24, 2021
@sam-gc sam-gc requested a review from egilmorez as a code owner September 24, 2021 23:02
@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2021 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 24, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (e5c8eed) and head commit (550b4a4).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 24, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (e5c8eed) and head commit (fdf0fb2).

@Feiyang1
Copy link
Member

Green CI looks so refreshing

@sam-gc sam-gc merged commit 49b0406 into master Sep 27, 2021
@sam-gc sam-gc deleted the sam-gc/action-code-settings branch September 27, 2021 18:11
@google-oss-bot google-oss-bot mentioned this pull request Sep 29, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lisajian lisajian lisajian approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@kevinthecheung kevinthecheung

@lisajian lisajian

@yuchenshi yuchenshi

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sendSignInLinkToEmail sends incorrect link on iOS after updating to Firebase 9
6 participants
@sam-gc @google-oss-bot @Feiyang1 @lisajian @yuchenshi @kevinthecheung