Skip to content

Remove "google-cloud-resource-prefix" header in favor of "database" url parameter in WebChannel requests. #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

mikelehen
Copy link
Contributor

I verified that the client still works against prod and that the ?database=... paremeter was included in every WebChannel network request.

NOTE that prior to this change we were including the "google-cloud-resource-prefix" header on non-streaming RPC requests, but with this change we will not include the header or use the "database" url parameter.

See b/72663769 for more info.

…rl parameter in WebChannel requests.

I verified that the client still works against prod and that the ?database=... paremeter was included in every WebChannel network request.

NOTE that prior to this change we were including the "google-cloud-resource-prefix" header on non-streaming RPC requests, but with this change we will not include the header or use the "database" url parameter.
Copy link

@jdimond jdimond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neato.

@mikelehen mikelehen merged commit 7681d03 into master Mar 7, 2018
@mikelehen mikelehen deleted the mikelehen/include-database-in-request branch March 7, 2018 22:28
@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants