Skip to content

trim all d.ts files in dist folder #5535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021
Merged

trim all d.ts files in dist folder #5535

merged 1 commit into from
Sep 23, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Sep 23, 2021

Relaxing the pattern to match all d.ts files to allow them to be trimmed. The original pattern was too specific and didn't match the typings file public.d.ts in @firebase/database, so it was not trimmed.

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2021

⚠️ No Changeset found

Latest commit: 4f7d462

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Sep 23, 2021
@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (ba9cba4) and head commit (f6a2a8c).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (ba9cba4) and head commit (f6a2a8c).

@Feiyang1 Feiyang1 merged commit 4e7aba4 into master Sep 23, 2021
@Feiyang1 Feiyang1 deleted the fei-prune-dts-fix branch September 23, 2021 17:21
@firebase firebase locked and limited conversation to collaborators Oct 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants