Skip to content

Export values from @firebase/database-compat #5533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2021
Merged

Export values from @firebase/database-compat #5533

merged 2 commits into from
Sep 22, 2021

Conversation

Feiyang1
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: ebb39a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Sep 22, 2021
@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

hiranya911
hiranya911 approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 22, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/database-compat

    Type Base (b835b4c) Head (3995435) Diff
    browser 17.9 kB 18.0 kB +109 B (+0.6%)
    esm5 21.0 kB 21.1 kB +109 B (+0.5%)
    module 17.9 kB 18.0 kB +109 B (+0.6%)

Test Logs

@Feiyang1 Feiyang1 merged commit ba9cba4 into master Sep 22, 2021
@Feiyang1 Feiyang1 deleted the fei-admin-database2 branch September 22, 2021 22:54
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 22, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (b835b4c) and head commit (3995435).

@firebase firebase locked and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

@jsdt jsdt Awaiting requested review from jsdt

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

Assignees

@hiranya911 hiranya911

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Feiyang1 @google-oss-bot @hiranya911