Skip to content

Release Fixes #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2018
Merged

Release Fixes #551

merged 4 commits into from
Mar 6, 2018

Conversation

jshcrowthe
Copy link
Contributor

There were some issues w/ the release process that needed to be addressed. Specifically:

  • The banner text was displayed incorrectly
  • The release CLI wasn't able to publish new packages properly

This commit addresses two issues:

- The banner text not correctly displaying on macOS due to the changed emoji spacing
- The release CLI throwing errors when trying to stage an unpublished package
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jshcrowthe jshcrowthe merged commit 03d224f into master Mar 6, 2018
@jshcrowthe jshcrowthe deleted the release-fixes branch March 6, 2018 20:19
@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants