Skip to content

Fix health metrics #5509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 22, 2021
Merged

Fix health metrics #5509

merged 9 commits into from
Sep 22, 2021

Conversation

Feiyang1
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2129848

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2021 •
edited
Loading

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@google-oss-bot google-oss-bot added the doc-changes PRs that affect docs label Sep 17, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 17, 2021 •
edited
Loading

Size Analysis Report

Affected Products

Diffs between base commit (f90c1d0) and head commit (5d0adc9) are too large (1,123,409 characters) to display.

Please check below links to see details from the original test log.

@Feiyang1 Feiyang1 removed the doc-changes PRs that affect docs label Sep 17, 2021
@Feiyang1 Feiyang1 requested a review from zwu52 as a code owner September 17, 2021 23:12
@Feiyang1 Feiyang1 changed the title [WIP] Fix health metrics Fix health metrics Sep 17, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 17, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 18.9 kB ? (?)
    esm5 ? 23.5 kB ? (?)
    main ? 24.6 kB ? (?)
    module ? 18.9 kB ? (?)

  • @firebase/analytics-compat

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 2.57 kB ? (?)
    esm5 ? 2.80 kB ? (?)
    main ? 3.24 kB ? (?)
    module ? 2.57 kB ? (?)

  • @firebase/api-documenter

    Type Base (f90c1d0) Head (5d0adc9) Diff
    main ? 3.95 kB ? (?)

  • @firebase/app

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 7.69 kB ? (?)
    esm5 ? 9.32 kB ? (?)
    main ? 10.2 kB ? (?)
    module ? 7.69 kB ? (?)

  • @firebase/app-check

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 20.2 kB ? (?)
    esm5 ? 24.1 kB ? (?)
    main ? 25.2 kB ? (?)
    module ? 20.2 kB ? (?)

  • @firebase/app-check-compat

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 1.91 kB ? (?)
    esm5 ? 2.11 kB ? (?)
    main ? 2.56 kB ? (?)
    module ? 1.91 kB ? (?)

  • @firebase/app-compat

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 5.28 kB ? (?)
    esm5 ? 6.13 kB ? (?)
    lite ? 4.06 kB ? (?)
    lite-esm5 ? 4.70 kB ? (?)
    main ? 6.73 kB ? (?)
    module ? 5.28 kB ? (?)

  • @firebase/auth-compat

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 19.7 kB ? (?)
    esm5 ? 26.8 kB ? (?)
    main ? 29.3 kB ? (?)
    module ? 19.7 kB ? (?)

  • @firebase/auth/cordova

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 178 kB ? (?)
    module ? 178 kB ? (?)

  • @firebase/auth/internal

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 162 kB ? (?)
    esm5 ? 211 kB ? (?)
    main ? 178 kB ? (?)
    module ? 162 kB ? (?)

  • @firebase/auth/react-native

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 143 kB ? (?)
    module ? 143 kB ? (?)

  • @firebase/component

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 8.61 kB ? (?)
    main ? 8.99 kB ? (?)
    module ? 8.61 kB ? (?)

  • @firebase/database

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 247 kB ? (?)
    esm5 ? 275 kB ? (?)
    main ? 280 kB ? (?)
    module ? 247 kB ? (?)

  • @firebase/database-compat

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 17.9 kB ? (?)
    esm5 ? 21.0 kB ? (?)
    main ? 22.9 kB ? (?)
    module ? 17.9 kB ? (?)

  • @firebase/firestore

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 225 kB ? (?)
    esm5 ? 282 kB ? (?)
    main ? 512 kB ? (?)
    module ? 225 kB ? (?)
    react-native ? 225 kB ? (?)

  • @firebase/firestore-compat

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 20.5 kB ? (?)
    esm5 ? 27.6 kB ? (?)
    main ? 20.9 kB ? (?)
    module ? 20.5 kB ? (?)
    react-native ? 20.5 kB ? (?)

  • @firebase/firestore-lite

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 71.6 kB ? (?)
    esm5 ? 84.8 kB ? (?)
    main ? 147 kB ? (?)
    module ? 71.6 kB ? (?)
    react-native ? 71.8 kB ? (?)

  • @firebase/functions

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 8.79 kB ? (?)
    esm5 ? 10.9 kB ? (?)
    main ? 11.6 kB ? (?)
    module ? 8.79 kB ? (?)

  • @firebase/functions-compat

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 1.67 kB ? (?)
    esm5 ? 1.83 kB ? (?)
    main ? 2.20 kB ? (?)
    module ? 1.67 kB ? (?)

  • @firebase/installations

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 17.2 kB ? (?)
    esm5 ? 22.3 kB ? (?)
    main ? 23.1 kB ? (?)
    module ? 17.2 kB ? (?)

  • @firebase/installations-compat

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 944 B ? (?)
    esm5 ? 1.16 kB ? (?)
    main ? 1.48 kB ? (?)
    module ? 944 B ? (?)

  • @firebase/logger

    Type Base (f90c1d0) Head (5d0adc9) Diff
    main ? 5.32 kB ? (?)
    module ? 4.65 kB ? (?)

  • @firebase/messaging

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 20.6 kB ? (?)
    esm5 ? 25.9 kB ? (?)
    main ? 26.6 kB ? (?)
    module ? 20.6 kB ? (?)

  • @firebase/messaging-compat

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 2.02 kB ? (?)
    esm5 ? 2.45 kB ? (?)
    main ? 2.83 kB ? (?)
    module ? 2.02 kB ? (?)

  • @firebase/messaging-sw

    Type Base (f90c1d0) Head (5d0adc9) Diff
    module ? 22.8 kB ? (?)

  • @firebase/performance

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 28.4 kB ? (?)
    esm5 ? 30.1 kB ? (?)
    main ? 30.6 kB ? (?)
    module ? 28.4 kB ? (?)

  • @firebase/performance-compat

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 1.10 kB ? (?)
    esm5 ? 1.37 kB ? (?)
    main ? 1.69 kB ? (?)
    module ? 1.10 kB ? (?)

  • @firebase/remote-config

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 18.8 kB ? (?)
    esm5 ? 23.7 kB ? (?)
    main ? 24.9 kB ? (?)
    module ? 18.8 kB ? (?)

  • @firebase/remote-config-compat

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 1.85 kB ? (?)
    esm5 ? 2.76 kB ? (?)
    main ? 3.09 kB ? (?)
    module ? 1.85 kB ? (?)

  • @firebase/rules-unit-testing

    Type Base (f90c1d0) Head (5d0adc9) Diff
    main ? 17.6 kB ? (?)

  • @firebase/storage

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 52.1 kB ? (?)
    esm5 ? 58.3 kB ? (?)
    main ? 53.5 kB ? (?)
    module ? 52.1 kB ? (?)

  • @firebase/storage-compat

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 5.67 kB ? (?)
    esm5 ? 8.41 kB ? (?)
    main ? 8.82 kB ? (?)
    module ? 5.67 kB ? (?)

  • @firebase/util

    Type Base (f90c1d0) Head (5d0adc9) Diff
    browser ? 21.8 kB ? (?)
    main ? 26.7 kB ? (?)
    module ? 21.8 kB ? (?)

  • @firebase/webchannel-wrapper

    Type Base (f90c1d0) Head (5d0adc9) Diff
    main ? 50.8 kB ? (?)
    module ? 44.7 kB ? (?)

  • firebase

    Click to show 29 binary size changes.
    Type Base (f90c1d0) Head (5d0adc9) Diff
    firebase-analytics-compat.js ? 27.6 kB ? (?)
    firebase-analytics.js ? 109 kB ? (?)
    firebase-app-check-compat.js ? 21.4 kB ? (?)
    firebase-app-check.js ? 79.6 kB ? (?)
    firebase-app-compat.js ? 23.1 kB ? (?)
    firebase-app.js ? 60.8 kB ? (?)
    firebase-auth-compat.js ? 124 kB ? (?)
    firebase-auth-cordova.js ? 460 kB ? (?)
    firebase-auth-react-native.js ? 433 kB ? (?)
    firebase-auth.js ? 411 kB ? (?)
    firebase-compat.js ? 751 kB ? (?)
    firebase-database-compat.js ? 170 kB ? (?)
    firebase-database.js ? 610 kB ? (?)
    firebase-firestore-compat.js ? 281 kB ? (?)
    firebase-firestore-lite.js ? 250 kB ? (?)
    firebase-firestore.js ? 793 kB ? (?)
    firebase-functions-compat.js ? 8.43 kB ? (?)
    firebase-functions.js ? 30.6 kB ? (?)
    firebase-messaging-compat.js ? 38.3 kB ? (?)
    firebase-messaging-sw.js ? 102 kB ? (?)
    firebase-messaging.js ? 100 kB ? (?)
    firebase-performance-compat.js ? 32.4 kB ? (?)
    firebase-performance-standalone-compat.es2017.js ? 84.1 kB ? (?)
    firebase-performance-standalone-compat.js ? 53.9 kB ? (?)
    firebase-performance.js ? 121 kB ? (?)
    firebase-remote-config-compat.js ? 29.1 kB ? (?)
    firebase-remote-config.js ? 111 kB ? (?)
    firebase-storage-compat.js ? 38.9 kB ? (?)
    firebase-storage.js ? 141 kB ? (?)

  • functions

    Type Base (f90c1d0) Head (5d0adc9) Diff
    main ? 46 B ? (?)

Test Logs

@google-oss-bot google-oss-bot added the doc-changes PRs that affect docs label Sep 18, 2021
@Feiyang1 Feiyang1 removed the doc-changes PRs that affect docs label Sep 20, 2021
@google-oss-bot google-oss-bot added the doc-changes PRs that affect docs label Sep 22, 2021
@Feiyang1 Feiyang1 merged commit 5823d0b into master Sep 22, 2021
@Feiyang1 Feiyang1 deleted the fei-health branch September 22, 2021 19:03
@firebase firebase locked and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yifanyang yifanyang yifanyang approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@zwu52 zwu52 Awaiting requested review from zwu52

Assignees

@egilmorez egilmorez

@hsubox76 hsubox76

Labels
doc-changes PRs that affect docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Feiyang1 @google-oss-bot @yifanyang @hsubox76 @egilmorez