Skip to content

Shim refactor #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2018
Merged

Shim refactor #550

merged 3 commits into from
Mar 5, 2018

Conversation

jshcrowthe
Copy link
Contributor

@jshcrowthe jshcrowthe commented Mar 5, 2018 •
edited
Loading

Organizes the @firebase/polyfill shims by Object (instead of by method) and adds a String.ts file for shimming the String prototype.

Fixes #549

@jshcrowthe jshcrowthe mentioned this pull request Mar 5, 2018
Closed
hiranya911
hiranya911 approved these changes Mar 5, 2018
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jshcrowthe jshcrowthe merged commit a0583f7 into master Mar 5, 2018
@jshcrowthe jshcrowthe deleted the shim-refactor branch March 5, 2018 18:45
@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@jshcrowthe jshcrowthe

Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firebase 4.10.x is no longer compatible with IE11
3 participants
@jshcrowthe @hiranya911 @google-oss-bot