Skip to content

do not run test:minified for @firebase/firestore in CI #5490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

Feiyang1
Copy link
Member

test:minified runs in a separate workflow

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2021

⚠️ No Changeset found

Latest commit: 50ac3a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file:
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
    If this change doesn't need a release, run `changeset add --empty`.
    

Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still fail PR submissions for Firestore if these tests fail? These tests are very important, as they are the only tests that can discover problems with minification. We never run them locally...

@Feiyang1
Copy link
Member Author

@Feiyang1 Feiyang1 merged commit 3846fb0 into master Sep 14, 2021
@Feiyang1 Feiyang1 deleted the fei-firestore-ci branch September 14, 2021 20:21
@firebase firebase locked and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants