Skip to content

Remove unnecessary lcov-result-merger dep from @firebase/messaging #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Remove unnecessary lcov-result-merger dep from @firebase/messaging #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/messaging/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"dependencies": {
"@firebase/messaging-types": "0.1.2",
"@firebase/util": "0.1.10",
"lcov-result-merger": "^2.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jshcrowthe not sure why this is in dependencies but might be needed in devdeps?

Copy link
Contributor

@jshcrowthe jshcrowthe Mar 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually isn't needed at all in this package. We use it at a higher level. It seems it snuck in, in #482

"tslib": "^1.9.0"
},
"devDependencies": {
Expand Down