Skip to content

Fix path typo in npm script #5455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2021
Merged

Fix path typo in npm script #5455

merged 1 commit into from
Sep 8, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Sep 7, 2021

This must have been overlooked somehow when cleaning out the scripts/exp directory and all references to it.

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2021

⚠️ No Changeset found

Latest commit: eead769

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2021

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@google-oss-bot google-oss-bot added the doc-changes PRs that affect docs label Sep 7, 2021
hiranya911
hiranya911 approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 4a47968 into master Sep 8, 2021
@hsubox76 hsubox76 deleted the ch-typo branch September 8, 2021 17:09
@firebase firebase locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

Assignees

@egilmorez egilmorez

Labels
doc-changes PRs that affect docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsubox76 @hiranya911 @egilmorez @google-oss-bot