-
Notifications
You must be signed in to change notification settings - Fork 938
Implement rest of RUTv2 features. #5360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
14d6218
Implement loading rules and withFunctionTriggersDisabled.
yuchenshi dd9543d
Implement clearFirestore and storage.
yuchenshi 3d7b13f
Add missing await.
yuchenshi 784b8bc
Add default bucketUrl.
yuchenshi d710a95
Use alternative method to clear bucket.
yuchenshi 96592bc
Use default param (review feedback).
yuchenshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
/** | ||
* @license | ||
* Copyright 2021 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { HostAndPort } from '../public_types'; | ||
import { makeUrl } from './url'; | ||
import fetch from 'node-fetch'; | ||
|
||
/** | ||
* @private | ||
*/ | ||
export async function loadDatabaseRules( | ||
hostAndPort: HostAndPort, | ||
databaseName: string, | ||
rules: string | ||
): Promise<void> { | ||
const url = makeUrl(hostAndPort, '/.settings/rules.json'); | ||
url.searchParams.append('ns', databaseName); | ||
const resp = await fetch(url, { | ||
method: 'PUT', | ||
headers: { Authorization: 'Bearer owner' }, | ||
body: rules | ||
}); | ||
|
||
if (!resp.ok) { | ||
throw new Error(await resp.text()); | ||
} | ||
} | ||
|
||
/** | ||
* @private | ||
*/ | ||
export async function loadFirestoreRules( | ||
hostAndPort: HostAndPort, | ||
projectId: string, | ||
rules: string | ||
): Promise<void> { | ||
const resp = await fetch( | ||
makeUrl(hostAndPort, `/emulator/v1/projects/${projectId}:securityRules`), | ||
{ | ||
method: 'PUT', | ||
body: JSON.stringify({ | ||
rules: { | ||
files: [{ content: rules }] | ||
} | ||
}) | ||
} | ||
); | ||
|
||
if (!resp.ok) { | ||
throw new Error(await resp.text()); | ||
} | ||
} | ||
|
||
/** | ||
* @private | ||
*/ | ||
export async function loadStorageRules( | ||
hostAndPort: HostAndPort, | ||
rules: string | ||
): Promise<void> { | ||
const resp = await fetch(makeUrl(hostAndPort, '/internal/setRules'), { | ||
method: 'PUT', | ||
headers: { | ||
'Content-Type': 'application/json' | ||
}, | ||
body: JSON.stringify({ | ||
rules: { | ||
files: [{ name: 'storage.rules', content: rules }] | ||
} | ||
}) | ||
}); | ||
if (!resp.ok) { | ||
throw new Error(await resp.text()); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/** | ||
* @license | ||
* Copyright 2021 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { HostAndPort } from '../public_types'; | ||
|
||
/** | ||
* Return a connectable hostname, replacing wildcard 0.0.0.0 or :: with loopback | ||
* addresses 127.0.0.1 / ::1 correspondingly. See below for why this is needed: | ||
* https://github.com/firebase/firebase-tools-ui/issues/286 | ||
* | ||
* This assumes emulators are running on the same device as fallbackHost (e.g. | ||
* hub), which should hold if both are started from the same CLI command. | ||
* @private | ||
*/ | ||
export function fixHostname(host: string, fallbackHost?: string): string { | ||
host = host.replace('[', '').replace(']', ''); // Remove IPv6 brackets | ||
if (host === '0.0.0.0') { | ||
host = fallbackHost || '127.0.0.1'; | ||
} else if (host === '::') { | ||
host = fallbackHost || '::1'; | ||
} | ||
return host; | ||
} | ||
|
||
/** | ||
* Create a URL with host, port, and path. Handles IPv6 bracketing correctly. | ||
* @private | ||
*/ | ||
export function makeUrl(hostAndPort: HostAndPort | string, path: string): URL { | ||
if (typeof hostAndPort === 'object') { | ||
const { host, port } = hostAndPort; | ||
if (host.includes(':')) { | ||
hostAndPort = `[${host}]:${port}`; | ||
} else { | ||
hostAndPort = `${host}:${port}`; | ||
} | ||
} | ||
const url = new URL(`http://${hostAndPort}/`); | ||
url.pathname = path; | ||
return url; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.