Skip to content

NPM Publish Access #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2018
Merged

NPM Publish Access #536

merged 1 commit into from
Feb 28, 2018

Conversation

jshcrowthe
Copy link
Contributor

As part of publishing scoped packages, we have to pass set the default access of our scoped packages. If we don't do this, the npm publish command will fail to publish new packages.

hiranya911
hiranya911 approved these changes Feb 28, 2018
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jshcrowthe jshcrowthe merged commit c1a07da into master Feb 28, 2018
@jshcrowthe jshcrowthe deleted the npm-publish-access branch February 28, 2018 19:36
@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@jshcrowthe jshcrowthe

Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jshcrowthe @hiranya911 @google-oss-bot