Move Messaging env checks to public methods #5357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feiyang1
reviewed
Aug 23, 2021
packages/messaging/src/api.ts
Outdated
Comment on lines
58
to
63
| .catch((e: Error) => { | ||
| if (e.message.includes(ErrorCode.UNSUPPORTED_BROWSER)) { | ||
| throw e; | ||
| } | ||
| throw ERROR_FACTORY.create(ErrorCode.INDEXED_DB_UNSUPPORTED); | ||
| }); |
There was a problem hiding this comment.
We can just use the error callback of then, which is much simpler.
Changeset File Check
|
Feiyang1
approved these changes
Aug 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure messaging env checks are only called when the user explicitly initializes messaging. If messaging is initialized by an internal API (Functions specifically) in an unsupported environment, it will leave ugly warnings that aren't catchable because the check is async and leaves a hanging promise. Since the user did not call messaging, the user can't do anything about it, and the warning is not helpful.
Also in Node 16, it actually exits and blocks further execution.